This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Fix assertion crashes on unmatched NOLINTBEGIN comments.
ClosedPublic

Authored by hokein on Nov 16 2021, 7:05 AM.

Details

Summary

The overload shouldSuppressDiagnostic seems unnecessary, and it is only
used in clangd.

This patch removes it and use the real one (suppression diagnostics are
discarded in clangd at the moment).

Fixes https://github.com/clangd/clangd/issues/929

Diff Detail

Event Timeline

hokein created this revision.Nov 16 2021, 7:05 AM
hokein requested review of this revision.Nov 16 2021, 7:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2021, 7:05 AM
kadircet accepted this revision.Nov 17 2021, 2:51 AM

thanks, lgtm!

This revision is now accepted and ready to land.Nov 17 2021, 2:51 AM