[llvm][ubsan] Inclusive language: replace use of blacklist HandleLLVMOptions.cmake

[ZarkoCA]

Summary

This patch changes it to ignorelist and contains a filename change for the
.txt file that's called.

[bjope]

llvm/cmake/modules/HandleLLVMOptions.cmake

875

Now I can't build llvm with ubsan, using an older version of clang, without getting lots of errors such as

`clang-13: error: unknown argument: '-fsanitize-ignorelist=/workspace/llvm/llvm-main-sanitize-ubsan/llvm/utils/sanitizers/ubsan_ignorelist.txt'`

that seems a bit unfortunate (or are there different requirements on which compiler version that is needed when building llvm depending on if I enable sanitizers or not?).

[lebedev.ri]

llvm/cmake/modules/HandleLLVMOptions.cmake

875

If that isn't supported even in the last released version of llvm then please revert immediately.

[ZarkoCA]

llvm/cmake/modules/HandleLLVMOptions.cmake

875

Reverted in 44a64afd43943ed6f47c37f61a6cd2e99c7287f3 sorry about this.

[ZarkoCA]

llvm/cmake/modules/HandleLLVMOptions.cmake

875

@lebedev.ri it looks like this option has been supported starting from Clang 13.0. Is that too new?

llvm/cmake/modules/HandleLLVMOptions.cmake

if(LLVM_USE_SANITIZER)
   if (LLVM_USE_SANITIZER MATCHES "(Undefined;)?Address(;Undefined)?")
     add_flag_if_supported("-fsanitize-address-use-after-scope"
                           FSANITIZE_USE_AFTER_SCOPE_FLAG)
   endif()
   if (LLVM_USE_SANITIZE_COVERAGE)
     append("-fsanitize=fuzzer-no-link" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
   endif()
   if (LLVM_USE_SANITIZER MATCHES ".*Undefined.*")
-    set(BLACKLIST_FILE "${CMAKE_SOURCE_DIR}/utils/sanitizers/ubsan_blacklist.txt")
-    if (EXISTS "${BLACKLIST_FILE}")
-      append("-fsanitize-blacklist=${BLACKLIST_FILE}"
+    set(IGNORELIST_FILE "${CMAKE_SOURCE_DIR}/utils/sanitizers/ubsan_ignorelist.txt")
+    if (EXISTS "${IGNORELIST_FILE}")
+      append("-fsanitize-ignorelist=${IGNORELIST_FILE}"
              CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
     endif()
   endif()
 endif()
 
 # Turn on -gsplit-dwarf if requested in debug builds.
 if (LLVM_USE_SPLIT_DWARF AND
     ((uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG") OR

llvm/utils/sanitizers/ubsan_ignorelist.txt

-# This blacklist should be applied when LLVM is built
+# This ignorelist should be applied when LLVM is built
 # with -fsanitize=undefined instrumentation. It exists
 # because libstdc++ has some undefined behavior issues
 # in some of the headers, in particular, stl_tree.h.
 
 # upcast of address with insufficient space for an object of type std::_Rb_tree_node<...>
 src:*bits/stl_tree.h
 
 # libstdc++ 4.8 creates a null reference when calling
 # data() on an empty vector: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59829
 src:*bits/stl_iterator.h
 src:*bits/stl_vector.h
 
 # libstdc++ 8.0.1 casts an under-aligned pointer to type type_info:
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85930
 src:*bits/shared_ptr_base.h