[clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check

[fwolff]

Summary

Fixes PR#52400. The tests for bugprone-throw-keyword-missing actually already contain exceptions as class members, but not as members with initializers, which was probably just an oversight.

[aaron.ballman]

LGTM, that is certainly not a place where one would put throw. :-D

[fwolff]

Thanks for reviewing this! Can you also commit it for me?

[aaron.ballman]

In D113585#3132793, @fwolff wrote:

Thanks for reviewing this! Can you also commit it for me?

Sure can! What name and email address would you like used for patch attribution? I'm in C standards meetings all this week so if someone else is able to land this before I get to it, I will not be hurt. :-)

[fwolff]

In D113585#3132810, @aaron.ballman wrote:

In D113585#3132793, @fwolff wrote:

Thanks for reviewing this! Can you also commit it for me?

Sure can! What name and email address would you like used for patch attribution? I'm in C standards meetings all this week so if someone else is able to land this before I get to it, I will not be hurt. :-)

Thanks! You can use the same name and email as in commit c3e3c762098e8d425731bb40f3b8b04dac1013f3.

[aaron.ballman]

I've commit on your behalf in 738e7f1231949ec248c1d8d154783338215613d1, thank you for the fix!

clang-tools-extra/clang-tidy/bugprone/ThrowKeywordMissingCheck.cpp

auto CtorInitializerList =
       cxxConstructorDecl(hasAnyConstructorInitializer(anything()));
 
   Finder->addMatcher(
       cxxConstructExpr(
           hasType(cxxRecordDecl(
               isSameOrDerivedFrom(matchesName("[Ee]xception|EXCEPTION")))),
           unless(anyOf(hasAncestor(stmt(
                            anyOf(cxxThrowExpr(), callExpr(), returnStmt()))),
-                       hasAncestor(varDecl()),
+                       hasAncestor(decl(anyOf(varDecl(), fieldDecl()))),
                        allOf(hasAncestor(CtorInitializerList),
                              unless(hasAncestor(cxxCatchStmt()))))))
           .bind("temporary-exception-not-thrown"),
       this);
 }
 
 void ThrowKeywordMissingCheck::check(const MatchFinder::MatchResult &Result) {
   const auto *TemporaryExpr =

clang-tools-extra/test/clang-tidy/checkers/bugprone-throw-keyword-missing.cpp

 
 void localVariableInitTest() {
   RegularException exc = RegularException();
   RegularException *excptr = new RegularException();
 }
 
 class CtorInitializerListTest {
   RegularException exc;
+  RegularException exc2{};
 
   CtorInitializerListTest() : exc(RegularException()) {}
 
   CtorInitializerListTest(int) try : exc(RegularException()) {
     // Constructor body
   } catch (...) {
     // CHECK-MESSAGES: :[[@LINE+1]]:5: warning: suspicious exception
     RegularException();