- User Since
- Nov 8 2021, 12:35 PM (54 w, 5 d)
Oct 21 2022
I suppose it sounds sensible to have the option of ignoring certain containers in this check; though I haven't needed it myself so far, which is also why I'm leaning against ignoring std::array by default. But I do not claim ultimate authority on this question, of course.
Jul 6 2022
Thanks for your help @philnik. I'm still unsure what exactly I should check for in the exception header; I went for
#if defined(_LIBCPP_ABI_VERSION) || defined(LIBCXXRT) || defined(LIBCXX_BUILDING_LIBCXXABI)
because the first two are used in libcxx/src/exception.cpp to indicate that the exception_pointer_cxxabi.ipp implementation is to be used, and it didn't work without the last one, but it doesn't really look right to me, so please comment.
Jul 5 2022
@Mordante I think the main problem were the inconsistent abilist files, which I have attempted to fix here (unfortunately generate-cxx-abilist didn't really work for me, as it created lots of other entries for things I didn't touch, so I had to do it manually). I've also rebased the patch, though the rebase went cleanly.
Jun 4 2022
Jun 3 2022
Apr 21 2022
Apr 20 2022
Thanks for reviewing this @Mordante! I think I've addressed all of your comments, and I've added a suppression for -Wgnu-inline-cpp-without-extern, which will hopefully fix the failing tests.
Apr 14 2022
Apr 13 2022
Thanks a lot for your analysis @jiixyj! Your analysis of the ABA problem makes sense to me.
Apr 12 2022
Thanks for your help @philnik. I have now revised my implementation so that the ABI break is no longer required.
Apr 11 2022
Mar 26 2022
Mar 25 2022
Thanks for reviewing this @ldionne!
Mar 23 2022
Mar 22 2022
Mar 21 2022
Thanks for the quick review @aaron.ballman! I think I've addressed your comments.
Mar 20 2022
Feb 8 2022
Jan 20 2022
Jan 18 2022
Jan 17 2022
Fixed the nits. Thanks for the review @aaron.ballman!
Rebased and ping @whisperity
Rebased again. Ping @lebedev.ri
@aaron.ballman Ping? I think I've responded to all comments so far; let me know if you still have concerns.
I've added the static_cast and an entry in the release notes. I'm not sure how to handle [[no_unique_address]], so I'd rather leave this to future work.
Dec 8 2021
Dec 6 2021
Dec 5 2021
Dec 4 2021
Thanks for your comments @whisperity! They should all be fixed now.
Thanks for your comments @whisperity. I think I've addressed them, could you have another look?
Dec 1 2021
Nov 30 2021
Nov 25 2021
This attempts to fix the remaining concerns/requests.
Nov 23 2021
Rebased after D114281 was merged.