Page MenuHomePhabricator

fwolff (Fabian Wolff)
User

Projects

User does not belong to any projects.

User Details

User Since
Mon, Nov 8, 12:35 PM (3 w, 1 d)

Recent Activity

Today

fwolff added a comment to D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.

I prefer to allow this extension; I even wonder whether not allowing 128-bit values was intentionally or an artifact of prohibiting (un)signed char. In general I prefer to allow __[u]int128_t to be used as a first-class citizen in libc++.

Tue, Nov 30, 12:25 PM · Restricted Project
fwolff updated the diff for D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.
Tue, Nov 30, 12:19 PM · Restricted Project

Thu, Nov 25

fwolff added inline comments to D114119: [libcxx] Fix potential lost wake-up in counting semaphore.
Thu, Nov 25, 5:05 PM · Restricted Project
fwolff updated the diff for D114119: [libcxx] Fix potential lost wake-up in counting semaphore.
Thu, Nov 25, 4:52 PM · Restricted Project
fwolff added inline comments to D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.
Thu, Nov 25, 4:46 PM · Restricted Project
fwolff updated the diff for D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.

This attempts to fix the remaining concerns/requests.

Thu, Nov 25, 4:40 PM · Restricted Project

Tue, Nov 23

fwolff updated the diff for D114119: [libcxx] Fix potential lost wake-up in counting semaphore.
Tue, Nov 23, 1:37 PM · Restricted Project
fwolff updated the diff for D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.

Rebased after D114281 was merged.

Tue, Nov 23, 1:18 PM · Restricted Project

Fri, Nov 19

fwolff requested review of D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration.
Fri, Nov 19, 4:32 PM · Restricted Project
fwolff requested review of D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs.
Fri, Nov 19, 3:15 PM · Restricted Project
fwolff updated the diff for D114272: [InstCombine] Add two optimizations for mul-and-icmp patterns.
Fri, Nov 19, 2:38 PM · Restricted Project
fwolff added a comment to D114272: [InstCombine] Add two optimizations for mul-and-icmp patterns.

This only shows that those tests aren't miscompiled

Fri, Nov 19, 2:34 PM · Restricted Project
fwolff added a comment to D114272: [InstCombine] Add two optimizations for mul-and-icmp patterns.

alive2 proofs?

Fri, Nov 19, 1:11 PM · Restricted Project
fwolff requested review of D114272: [InstCombine] Add two optimizations for mul-and-icmp patterns.
Fri, Nov 19, 12:40 PM · Restricted Project
fwolff updated the diff for D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination.
Fri, Nov 19, 8:43 AM · Restricted Project
fwolff updated the diff for D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination.

@fhahn Fixed and rebased, thanks for the review! (And I'll need someone to commit this for me. You can use name and email as in commit 6259016361345e09f0607ef4e037e00bcbe4bd40 for attribution. Thanks!)

Fri, Nov 19, 5:42 AM · Restricted Project

Thu, Nov 18

fwolff added a comment to D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.

On both of those questions (but especially the second), I tentatively propose that we (I?) should granularize <random> into <__random/*.h> before landing this PR. (Which will merge-conflict horribly, no matter which way we do things. Unless people think we should just land this one ASAP. I wouldn't object to that, but I wouldn't necessarily encourage it either.)

Thu, Nov 18, 4:23 PM · Restricted Project
fwolff added inline comments to D114119: [libcxx] Fix potential lost wake-up in counting semaphore.
Thu, Nov 18, 3:29 PM · Restricted Project
fwolff updated the diff for D114119: [libcxx] Fix potential lost wake-up in counting semaphore.
Thu, Nov 18, 3:21 PM · Restricted Project
fwolff added a comment to D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check.

Thanks for the quick review! Can you also commit it for me? You can use name and email as in commit 738e7f1231949ec248c1d8d154783338215613d1. Thank you!

Thu, Nov 18, 3:07 PM · Restricted Project
fwolff requested review of D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check.
Thu, Nov 18, 2:13 PM · Restricted Project
fwolff updated the diff for D114119: [libcxx] Fix potential lost wake-up in counting semaphore.
Thu, Nov 18, 1:11 PM · Restricted Project
fwolff updated the diff for D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.

Is uniform_int_distribution really the only distribution with this kind of problem? What about, I dunno, binomial_distribution?

Thu, Nov 18, 1:05 PM · Restricted Project
fwolff updated the diff for D113868: [libcxx] Cast to the right `difference_type` in various algorithms.

Rebased on rG4a8734deb7d5, so this is now ready, I think.

Thu, Nov 18, 11:15 AM · Restricted Project
fwolff updated the diff for D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination.
Thu, Nov 18, 10:58 AM · Restricted Project

Wed, Nov 17

fwolff updated the diff for D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination.
Wed, Nov 17, 4:56 PM · Restricted Project
fwolff requested review of D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type.
Wed, Nov 17, 4:46 PM · Restricted Project
fwolff updated the diff for D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination.
Wed, Nov 17, 3:40 PM · Restricted Project
fwolff updated the diff for D114119: [libcxx] Fix potential lost wake-up in counting semaphore.

I've added a simple test, although I couldn't reproduce the issue locally either.

Wed, Nov 17, 2:46 PM · Restricted Project
fwolff updated the diff for D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination.
Wed, Nov 17, 1:50 PM · Restricted Project
fwolff requested review of D114119: [libcxx] Fix potential lost wake-up in counting semaphore.
Wed, Nov 17, 1:31 PM · Restricted Project

Tue, Nov 16

fwolff requested review of D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination.
Tue, Nov 16, 2:11 PM · Restricted Project
fwolff added a comment to D113835: [CVP] Remove ashr of -1 or 0.

Thanks for the review @reames! I've added another test to cover the edge cases. Can you commit this for me?

Sure. To confirm, this is code you intend to contribute to llvm under the terms of the relevant licenses and agreements, and have the authority to agree to same?

Tue, Nov 16, 11:34 AM · Restricted Project

Mon, Nov 15

fwolff updated the diff for D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute.

Thanks again for your feedback @salman-javed-nz! I think I've addressed all of your comments now.

Mon, Nov 15, 2:13 PM · Restricted Project
fwolff updated the diff for D113868: [libcxx] Cast to the right `difference_type` in various algorithms.

@Quuxplusone I think I've addressed all of your comments now.

Mon, Nov 15, 1:58 PM · Restricted Project
fwolff added inline comments to D113868: [libcxx] Cast to the right `difference_type` in various algorithms.
Mon, Nov 15, 1:46 PM · Restricted Project
fwolff added a comment to D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check.

Thanks for reviewing this! Can you also commit it for me?

Sure can! What name and email address would you like used for patch attribution? I'm in C standards meetings all this week so if someone else is able to land this before I get to it, I will not be hurt. :-)

Mon, Nov 15, 1:41 PM · Restricted Project
fwolff added inline comments to D113868: [libcxx] Cast to the right `difference_type` in various algorithms.
Mon, Nov 15, 1:38 PM · Restricted Project
fwolff added inline comments to D113863: [clang-tidy] Make `readability-container-data-pointer` more robust.
Mon, Nov 15, 1:30 PM · Restricted Project
fwolff updated the diff for D113863: [clang-tidy] Make `readability-container-data-pointer` more robust.
Mon, Nov 15, 1:30 PM · Restricted Project
fwolff added a comment to D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check.

Thanks for reviewing this! Can you also commit it for me?

Mon, Nov 15, 1:23 PM · Restricted Project
fwolff updated the diff for D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions.

Thanks for your suggestions @whisperity! I have fixed both of them now.

Mon, Nov 15, 1:15 PM · Restricted Project
fwolff updated the diff for D113835: [CVP] Remove ashr of -1 or 0.

Thanks for the review @reames! I've added another test to cover the edge cases. Can you commit this for me?

Mon, Nov 15, 12:57 PM · Restricted Project
fwolff updated the diff for D113868: [libcxx] Cast to the right `difference_type` in various algorithms.

Fix the same problem in the other algorithms

Mon, Nov 15, 12:34 PM · Restricted Project
fwolff added a comment to D113834: [X86] Fix crash with inline asm using wrong register name.

Thanks again for the review. Can you also commit this for me @pengfei? (The libFuzzer test failure seems unrelated.)

Mon, Nov 15, 9:47 AM · Restricted Project

Sun, Nov 14

fwolff requested review of D113868: [libcxx] Cast to the right `difference_type` in various algorithms.
Sun, Nov 14, 4:56 PM · Restricted Project
fwolff updated the diff for D113834: [X86] Fix crash with inline asm using wrong register name.

Use return None; instead of return {};.

Sun, Nov 14, 3:48 PM · Restricted Project
fwolff updated the diff for D113863: [clang-tidy] Make `readability-container-data-pointer` more robust.
Sun, Nov 14, 2:26 PM · Restricted Project
fwolff updated the diff for D113863: [clang-tidy] Make `readability-container-data-pointer` more robust.
Sun, Nov 14, 2:22 PM · Restricted Project
fwolff requested review of D113863: [clang-tidy] Make `readability-container-data-pointer` more robust.
Sun, Nov 14, 2:18 PM · Restricted Project
fwolff updated the diff for D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute.

Thanks for your comments @salman-javed-nz! I have expanded the tests now according to your suggestions.

Sun, Nov 14, 11:51 AM · Restricted Project
fwolff updated the diff for D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers.

Thanks for reviewing this @carlosgalvezp! I have removed the "dead" test and put it into a follow-up issue (PR#52502).

Sun, Nov 14, 11:18 AM · Restricted Project
fwolff updated the diff for D113834: [X86] Fix crash with inline asm using wrong register name.

I've changed it to issue an error instead now. Is this what you had in mind @pengfei?

Sun, Nov 14, 10:52 AM · Restricted Project

Sat, Nov 13

fwolff requested review of D113835: [CVP] Remove ashr of -1 or 0.
Sat, Nov 13, 2:32 PM · Restricted Project
fwolff requested review of D113834: [X86] Fix crash with inline asm using wrong register name.
Sat, Nov 13, 1:24 PM · Restricted Project
fwolff requested review of D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute.
Sat, Nov 13, 10:11 AM · Restricted Project
fwolff requested review of D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides.
Sat, Nov 13, 9:06 AM · Restricted Project

Fri, Nov 12

fwolff requested review of D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions.
Fri, Nov 12, 1:38 PM · Restricted Project

Thu, Nov 11

fwolff requested review of D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers.
Thu, Nov 11, 1:10 PM · Restricted Project
fwolff added inline comments to D113518: [clang][Sema] Create delegating constructors even in templates.
Thu, Nov 11, 12:09 PM · Restricted Project, Restricted Project
fwolff updated the diff for D113518: [clang][Sema] Create delegating constructors even in templates.
Thu, Nov 11, 12:08 PM · Restricted Project, Restricted Project

Wed, Nov 10

fwolff added a comment to D113518: [clang][Sema] Create delegating constructors even in templates.

Thanks for your review @carlosgalvezp! I have addressed your inline comments. I'm not sure about the failing test, but it looks like a regression test internal to libFuzzer? Maybe it goes away with the rebuild.

Wed, Nov 10, 1:23 PM · Restricted Project, Restricted Project
fwolff updated the diff for D113518: [clang][Sema] Create delegating constructors even in templates.
Wed, Nov 10, 1:15 PM · Restricted Project, Restricted Project
fwolff updated the diff for D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions.

The test failed on Windows. I don't have a machine to reproduce this, but maybe adding -fno-delayed-template-parsing helps.

Wed, Nov 10, 10:51 AM · Restricted Project
fwolff requested review of D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check.
Wed, Nov 10, 10:42 AM · Restricted Project

Tue, Nov 9

fwolff requested review of D113518: [clang][Sema] Create delegating constructors even in templates.
Tue, Nov 9, 2:05 PM · Restricted Project, Restricted Project
fwolff requested review of D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check.
Tue, Nov 9, 12:27 PM · Restricted Project
fwolff requested review of D113499: [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions.
Tue, Nov 9, 10:44 AM · Restricted Project
fwolff added a comment to D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check.

Thanks for reviewing this! Can you (or someone else) commit this for me? I don't have commit access.

Tue, Nov 9, 9:33 AM · Restricted Project

Mon, Nov 8

fwolff requested review of D113429: [clang-tidy] Use `hasCanonicalType()` matcher in `bugprone-unused-raii` check.
Mon, Nov 8, 12:47 PM · Restricted Project