Page MenuHomePhabricator

[OpenMP][FIX] Introduce and use a simple generic-mode barrier
ClosedPublic

Authored by jdoerfert on Oct 31 2021, 12:52 PM.

Details

Summary

Before we had aligned barriers the __kmpc_barrier_simple_spmd was
OK to be used in the custom state machine. Now that SPMD barriers are
assumed to be aligned we need to use a "generic" barrier in places
that are not aligned.

Diff Detail

Unit TestsFailed

TimeTest
1,260 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::exitcode.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -shared-libasan -g -Wno-deprecated-declarations /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/exitcode.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxDynamicConfig/TestCases/Output/exitcode.cpp.tmp
1,610 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::exitcode.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -g -Wno-deprecated-declarations /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/exitcode.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/exitcode.cpp.tmp

Event Timeline

jdoerfert created this revision.Oct 31 2021, 12:52 PM
jdoerfert requested review of this revision.Oct 31 2021, 12:52 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 31 2021, 12:52 PM
jdoerfert updated this revision to Diff 383706.Oct 31 2021, 7:51 PM

Add function to old RT as well

This revision is now accepted and ready to land.Nov 1 2021, 11:01 AM
This revision was landed with ongoing or failed builds.Nov 2 2021, 9:23 PM
This revision was automatically updated to reflect the committed changes.