This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Disable cfi-version test on AIX
ClosedPublic

Authored by Jake-Egan on Oct 26 2021, 9:05 PM.

Details

Summary

.debug_frame is not emitted on AIX, so this patch disables the test.

Diff Detail

Event Timeline

Jake-Egan created this revision.Oct 26 2021, 9:05 PM
Jake-Egan requested review of this revision.Oct 26 2021, 9:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2021, 9:05 PM
Jake-Egan edited the summary of this revision. (Show Details)Oct 26 2021, 9:07 PM
Jake-Egan added a reviewer: shchenz.

I think we are using trace table on AIX instead of .debug_frame/.eh_frame . So marking .debug_frame as not emitted on AIX should be right? @xingxue @hubert.reinterpretcast

jsji added a subscriber: jsji.Oct 27 2021, 6:49 AM

I think we are using trace table on AIX instead of .debug_frame/.eh_frame . So marking .debug_frame as not emitted on AIX should be right? @xingxue @hubert.reinterpretcast

The section name is different, but we do have SSUBTYPE_DWFRAME (.dwframe) in XCOFF.

I think we are using trace table on AIX instead of .debug_frame/.eh_frame . So marking .debug_frame as not emitted on AIX should be right? @xingxue @hubert.reinterpretcast

The section name is different, but we do have SSUBTYPE_DWFRAME (.dwframe) in XCOFF.

Yeah, we defined this section, but we will not generate this section now. For the changed test, llc on AIX will not generate .dwframe section for it. And commercial XLC on AIX will also not generate this section.

Do you know will this section be supported in the future? If so, we can just make this case XFAIL.
But if there is no plan to support .dwframe section, we can just mark it as not emit like this patch does?

jsji accepted this revision.Oct 27 2021, 7:42 PM

Do you know will this section be supported in the future? If so, we can just make this case XFAIL.
But if there is no plan to support .dwframe section, we can just mark it as not emit like this patch does?

OK to not emit for now. We can change back once we start to emit it.

This revision is now accepted and ready to land.Oct 27 2021, 7:42 PM

Do you know will this section be supported in the future? If so, we can just make this case XFAIL.
But if there is no plan to support .dwframe section, we can just mark it as not emit like this patch does?

OK to not emit for now. We can change back once we start to emit it.

Thanks.

LGTM too.

shchenz accepted this revision.Oct 27 2021, 8:40 PM
Jake-Egan edited the summary of this revision. (Show Details)Oct 28 2021, 6:10 AM
This revision was landed with ongoing or failed builds.Oct 31 2021, 6:33 AM
This revision was automatically updated to reflect the committed changes.