Page MenuHomePhabricator

[clangd] Add integration test for crash handling
ClosedPublic

Authored by sammccall on Oct 26 2021, 11:23 AM.

Details

Summary

This replaces the test removed in 51be7061d025139ba66869d5d99c7157a3ae9edd
It is more principled and tests more critical cases: a crash while parsing.

We need two pieces of plumbing:

  • a way to re-enable the crashing #pragmas via a flag, to test parse crashes
  • a bit of reshuffling around ASTWorker execution so that we set up the crash handler in both sync/async modes. Sync mode is useful for debugging, so I tested both.

Diff Detail

Event Timeline

sammccall created this revision.Oct 26 2021, 11:23 AM
sammccall requested review of this revision.Oct 26 2021, 11:23 AM
kadircet accepted this revision.Oct 27 2021, 1:51 AM

thanks, lgtm!

This revision is now accepted and ready to land.Oct 27 2021, 1:51 AM
This revision was automatically updated to reflect the committed changes.