- User Since
- Dec 15 2020, 10:53 AM (80 w, 5 d)
Oct 26 2021
I think this should work-around end-to-end test failure on Windows:
diff --git a/clang-tools-extra/clangd/test/crash.test b/clang-tools-extra/clangd/test/crash.test index 1197e1ab07c3..68ef54808f09 100644 --- a/clang-tools-extra/clangd/test/crash.test +++ b/clang-tools-extra/clangd/test/crash.test @@ -1,3 +1,4 @@ +# REQUIRES: shell # Overflow the recursive json parser, prevent `yes` error due to broken pipe and `clangd` SIGSEGV from being treated as a failure. # RUN: (yes '[' || :) | head -n 50000 | (clangd --input-style=delimited 2>&1 || :) | FileCheck %s # CHECK: Signalled while processing message:
Alternatively, the test can be completely disabled for the time being.
Oct 25 2021
Are there any blockers to landing this?
Oct 12 2021
I don't have commit access, so would appreciate if you commit it, thanks!
Updated the AST worker crash handler to avoid std::string copy: used a char pointer instead.
Oct 8 2021
I've opted for simulating signals in the unit test on Windows by manually calling the signal handler, and added a list test to test the crash handling integration end-to-end.
Addressed feedback from the last round of comments. Sorry for the delay!
Sep 14 2021
I've tried making an integration test in addition to the unit test, but I couldn't find a way to make lit ignore the crashed process exit status:
FAIL: Clangd :: crash.test (1049 of 1049) ******************** TEST 'Clangd :: crash.test' FAILED ******************** Script: -- : 'RUN: at line 2'; yes '[' | head -n 50000 | sh -c "clangd --input-style=delimited 2>&1 || true" -- Exit Code: 141
updated revision description for final review after renaming the class
addressed review comments
Sep 10 2021
Thank you for such a prompt and thorough review!
Sep 9 2021
Dec 16 2020
Do you need me to commit on your behalf?
Yes, I don't have commit access. The attribution line looks good to me. Thank you! 🙂
Updated to address review comments.