Page MenuHomePhabricator

0x1eaf (Emma Blink)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 15 2020, 10:53 AM (80 w, 5 d)

Recent Activity

Oct 26 2021

0x1eaf added a comment to D109506: [clangd] Print current request context along with the stack trace.

I think this should work-around end-to-end test failure on Windows:

diff --git a/clang-tools-extra/clangd/test/crash.test b/clang-tools-extra/clangd/test/crash.test
index 1197e1ab07c3..68ef54808f09 100644
--- a/clang-tools-extra/clangd/test/crash.test
+++ b/clang-tools-extra/clangd/test/crash.test
@@ -1,3 +1,4 @@
+# REQUIRES: shell
 # Overflow the recursive json parser, prevent `yes` error due to broken pipe and `clangd` SIGSEGV from being treated as a failure.
 # RUN: (yes '[' || :) | head -n 50000 | (clangd --input-style=delimited 2>&1 || :) | FileCheck %s
 #      CHECK: Signalled while processing message:

Alternatively, the test can be completely disabled for the time being.

Oct 26 2021, 5:19 AM · Restricted Project, Restricted Project

Oct 25 2021

0x1eaf added a comment to D109506: [clangd] Print current request context along with the stack trace.

Are there any blockers to landing this?

Oct 25 2021, 8:00 AM · Restricted Project, Restricted Project

Oct 12 2021

0x1eaf added a comment to D109506: [clangd] Print current request context along with the stack trace.

I don't have commit access, so would appreciate if you commit it, thanks!

Oct 12 2021, 11:36 AM · Restricted Project, Restricted Project
0x1eaf updated the diff for D109506: [clangd] Print current request context along with the stack trace.

Updated the AST worker crash handler to avoid std::string copy: used a char pointer instead.

Oct 12 2021, 11:25 AM · Restricted Project, Restricted Project

Oct 8 2021

0x1eaf added a comment to D109506: [clangd] Print current request context along with the stack trace.

I've opted for simulating signals in the unit test on Windows by manually calling the signal handler, and added a list test to test the crash handling integration end-to-end.

Oct 8 2021, 8:58 AM · Restricted Project, Restricted Project
0x1eaf updated the diff for D109506: [clangd] Print current request context along with the stack trace.

Addressed feedback from the last round of comments. Sorry for the delay!

Oct 8 2021, 8:52 AM · Restricted Project, Restricted Project

Sep 14 2021

0x1eaf added a comment to D109506: [clangd] Print current request context along with the stack trace.

I've tried making an integration test in addition to the unit test, but I couldn't find a way to make lit ignore the crashed process exit status:

FAIL: Clangd :: crash.test (1049 of 1049)
******************** TEST 'Clangd :: crash.test' FAILED ********************
Script:
--
: 'RUN: at line 2';   yes '[' | head -n 50000 | sh -c "clangd --input-style=delimited 2>&1 || true"
--
Exit Code: 141
Sep 14 2021, 10:54 AM · Restricted Project, Restricted Project
0x1eaf updated the diff for D109506: [clangd] Print current request context along with the stack trace.

updated revision description for final review after renaming the class

Sep 14 2021, 10:41 AM · Restricted Project, Restricted Project
0x1eaf updated the diff for D109506: [clangd] Print current request context along with the stack trace.

addressed review comments

Sep 14 2021, 10:25 AM · Restricted Project, Restricted Project
0x1eaf abandoned D109772: [clangd] Print current request context along with the stack trace.
Sep 14 2021, 10:23 AM · Restricted Project, Restricted Project
0x1eaf requested review of D109772: [clangd] Print current request context along with the stack trace.
Sep 14 2021, 10:17 AM · Restricted Project, Restricted Project

Sep 10 2021

0x1eaf added inline comments to D109506: [clangd] Print current request context along with the stack trace.
Sep 10 2021, 9:46 AM · Restricted Project, Restricted Project
0x1eaf added a comment to D109506: [clangd] Print current request context along with the stack trace.

Thank you for such a prompt and thorough review!

Sep 10 2021, 7:45 AM · Restricted Project, Restricted Project

Sep 9 2021

0x1eaf requested review of D109506: [clangd] Print current request context along with the stack trace.
Sep 9 2021, 6:52 AM · Restricted Project, Restricted Project

Dec 16 2020

0x1eaf added a comment to D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines.

Do you need me to commit on your behalf?

Yes, I don't have commit access. The attribution line looks good to me. Thank you! 🙂

Dec 16 2020, 11:30 AM · Restricted Project, Restricted Project
0x1eaf updated the diff for D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines.

Updated to address review comments.

Dec 16 2020, 11:27 AM · Restricted Project, Restricted Project
0x1eaf updated the summary of D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines.
Dec 16 2020, 8:45 AM · Restricted Project, Restricted Project
0x1eaf requested review of D93402: [clang-tidy] prevent readability-identifier-naming from triggering on implicit VarDecls in coroutines.
Dec 16 2020, 8:41 AM · Restricted Project, Restricted Project