Replace some custom matrix diagnostic kinds with the more generic
err_builtin_invalid_arg_type introduced in D111985.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I'm fine with this change in general... but did this not manage to break any tests?
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
16654 | Can you make these be a "select" instead? It makes it really difficult to localize if we do this. |
In general, I like the direction of this cleanup. Thanks!
Precommit CI says things are broken: https://buildkite.com/llvm-project/premerge-checks/builds/62247#63e5ea73-b0b3-4df4-898a-dd05d1f4bf81
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
16582 | 1 nit: On the 'select' lines, please put a /**/ comment next to the integer to explain what it is. If they were all closer to eachother, I'd suggest doing an enum for them, but the comment should be good enough. |
clang/lib/Sema/SemaChecking.cpp | ||
---|---|---|
16582 | done, thanks! |
clang-format: please reformat the code