This is an archive of the discontinued LLVM Phabricator instance.

Differential D112217

[flang][flang-omp-report] Remove the loop workarounds for nowait clause
ClosedPublic

Authored by josh.mottley.arm on Oct 21 2021, 5:27 AM.

Details

Reviewers
sscalpone
jdoerfert
awarzynski
kiranchandramohan
Leporacanthicus
Commits
rG2aec2549e8e5: [flang][flang-omp-report] Remove the loop workarounds for nowait clause
Summary

In a "Worksharing-loop construct", one can add a nowait clause at the end
of the loop (i.e. at the loop tail). This clause wasn't associated with
the corresponding loop when originally worked on in flang-omp-report.
Note that this refers to parsing and parse-tree generation. To work
around it, it was needed to track such clauses and the loops.
This should no longer be required (and in fact no longer works) and so
was removed. This results in 'curLoopLogRecord' and 'loopLogRecordStack' and
all references to them being removed. This also allows for
'constructClauses' to be swapped from std::deque to llvm::SmallVector.
Lastly a new test has been added testing the "nowait" clauses in a
variety of ways.

Diff Detail

Event Timeline

josh.mottley.arm created this revision.Oct 21 2021, 5:27 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptOct 21 2021, 5:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
josh.mottley.arm requested review of this revision.Oct 21 2021, 5:27 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptOct 21 2021, 5:27 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1, jdoerfert. · View Herald Transcript
josh.mottley.arm added reviewers: awarzynski, kiranchandramohan, Leporacanthicus.Oct 21 2021, 5:29 AM
Harbormaster completed remote builds in B129918: Diff 381225.Oct 21 2021, 5:32 AM
josh.mottley.arm updated this revision to Diff 381244.Oct 21 2021, 6:31 AM

Manually ran clang-format of flang-omp-report-visistor.cpp as git-clang-format
not correctly formatting the code.

Harbormaster completed remote builds in B129930: Diff 381244.Oct 21 2021, 6:37 AM
awarzynski accepted this revision.Oct 22 2021, 7:31 AM

Makes sense, thanks for working on this! It's always nice to see a reduction in the number of LOC :) LGTM!

flang/test/Examples/omp-nowait.f90
2

[nit] This comment doesn't add much here. Perhaps just delete?

8

Not true ;-)

This revision is now accepted and ready to land.Oct 22 2021, 7:31 AM
josh.mottley.arm updated this revision to Diff 382280.Oct 26 2021, 6:05 AM

Removed unnecessary comments in 'omp-nowait.f90'.

josh.mottley.arm marked 2 inline comments as done.Oct 26 2021, 6:09 AM
Harbormaster completed remote builds in B130674: Diff 382280.Oct 26 2021, 6:11 AM
kiranchandramohan accepted this revision.Oct 28 2021, 5:14 AM

LGTM.

Closed by commit rG2aec2549e8e5: [flang][flang-omp-report] Remove the loop workarounds for nowait clause (authored by josh.mottley.arm). · Explain WhyNov 4 2021, 7:24 AM
This revision was automatically updated to reflect the committed changes.
josh.mottley.arm added a commit: rG2aec2549e8e5: [flang][flang-omp-report] Remove the loop workarounds for nowait clause.

Revision Contents

PathSize
flang/
examples/
flang-omp-report-plugin/
17 lines
38 lines
4 lines
test/
Examples/
301 lines

Diff 381225

flang/examples/flang-omp-report-plugin/flang-omp-report-visitor.h

//===-- examples/flang-omp-report-plugin/flang-omp-report-visitor.h -------===// //===-- examples/flang-omp-report-plugin/flang-omp-report-visitor.h -------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef FORTRAN_FLANG_OMP_REPORT_VISITOR_H #ifndef FORTRAN_FLANG_OMP_REPORT_VISITOR_H
#define FORTRAN_FLANG_OMP_REPORT_VISITOR_H #define FORTRAN_FLANG_OMP_REPORT_VISITOR_H
#include "flang/Parser/parse-tree-visitor.h" #include "flang/Parser/parse-tree-visitor.h"
#include "flang/Parser/parse-tree.h" #include "flang/Parser/parse-tree.h"
#include "flang/Parser/parsing.h" #include "flang/Parser/parsing.h"
#include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringRef.h"
#include <deque>
#include <string> #include <string>
namespace Fortran { namespace Fortran {
namespace parser { namespace parser {
struct ClauseInfo { struct ClauseInfo {
std::string clause; std::string clause;
std::string clauseDetails; std::string clauseDetails;
ClauseInfo() {} ClauseInfo() {}
Show All 28 Linesstruct OpenMPCounterVisitor {
std::string getName(const OmpWrapperType &w); std::string getName(const OmpWrapperType &w);
std::string getName(const OpenMPDeclarativeConstruct &c); std::string getName(const OpenMPDeclarativeConstruct &c);
std::string getName(const OpenMPConstruct &c); std::string getName(const OpenMPConstruct &c);
template <typename A> bool Pre(const A &) { return true; } template <typename A> bool Pre(const A &) { return true; }
template <typename A> void Post(const A &) {} template <typename A> void Post(const A &) {}
bool Pre(const OpenMPDeclarativeConstruct &c); bool Pre(const OpenMPDeclarativeConstruct &c);
bool Pre(const OpenMPConstruct &c); bool Pre(const OpenMPConstruct &c);
bool Pre(const OmpEndLoopDirective &c);
bool Pre(const DoConstruct &);
void Post(const OpenMPDeclarativeConstruct &); void Post(const OpenMPDeclarativeConstruct &);
void Post(const OpenMPConstruct &); void Post(const OpenMPConstruct &);
void PostConstructsCommon(); void PostConstructsCommon();
void Post(const OmpEndLoopDirective &c);
void Post(const OmpProcBindClause::Type &c); void Post(const OmpProcBindClause::Type &c);
void Post(const OmpDefaultClause::Type &c); void Post(const OmpDefaultClause::Type &c);
void Post(const OmpDefaultmapClause::ImplicitBehavior &c); void Post(const OmpDefaultmapClause::ImplicitBehavior &c);
void Post(const OmpDefaultmapClause::VariableCategory &c); void Post(const OmpDefaultmapClause::VariableCategory &c);
void Post(const OmpScheduleModifierType::ModType &c); void Post(const OmpScheduleModifierType::ModType &c);
void Post(const OmpLinearModifier::Type &c); void Post(const OmpLinearModifier::Type &c);
void Post(const OmpDependenceType::Type &c); void Post(const OmpDependenceType::Type &c);
void Post(const OmpMapType::Type &c); void Post(const OmpMapType::Type &c);
void Post(const OmpScheduleClause::ScheduleType &c); void Post(const OmpScheduleClause::ScheduleType &c);
void Post(const OmpIfClause::DirectiveNameModifier &c); void Post(const OmpIfClause::DirectiveNameModifier &c);
void Post(const OmpCancelType::Type &c); void Post(const OmpCancelType::Type &c);
void Post(const OmpClause &c); void Post(const OmpClause &c);
void PostClauseCommon(const ClauseInfo &ci); void PostClauseCommon(const ClauseInfo &ci);
void Post(const DoConstruct &);
std::string clauseDetails{""}; std::string clauseDetails{""};
llvm::SmallVector<LogRecord> constructClauses;
// curLoopLogRecord and loopLogRecordStack store
// pointers to this datastructure's entries. Hence a
// vector cannot be used since pointers are invalidated
// on resize. Next best option seems to be deque. Also a
// list cannot be used since YAML gen requires a
// datastructure which can be accessed through indices.
std::deque<LogRecord> constructClauses;
LogRecord *curLoopLogRecord{nullptr};
llvm::SmallVector<LogRecord *> loopLogRecordStack;
llvm::SmallVector<OmpWrapperType *> ompWrapperStack; llvm::SmallVector<OmpWrapperType *> ompWrapperStack;
llvm::DenseMap<OmpWrapperType *, llvm::SmallVector<ClauseInfo>> clauseStrings; llvm::DenseMap<OmpWrapperType *, llvm::SmallVector<ClauseInfo>> clauseStrings;
Parsing *parsing{nullptr}; Parsing *parsing{nullptr};
}; };
} // namespace parser } // namespace parser
} // namespace Fortran } // namespace Fortran
#endif /* FORTRAN_FLANG_OMP_REPORT_VISITOR_H */ #endif /* FORTRAN_FLANG_OMP_REPORT_VISITOR_H */

flang/examples/flang-omp-report-plugin/flang-omp-report-visitor.cpp

//===-- examples/flang-omp-report-plugin/flang-omp-report-visitor.cpp -----===// //===-- examples/flang-omp-report-plugin/flang-omp-report-visitor.cpp -----===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 142 Lines • ▼ Show 20 Linesbool OpenMPCounterVisitor::Pre(const OpenMPDeclarativeConstruct &c) {
ompWrapperStack.push_back(ow); ompWrapperStack.push_back(ow);
return true; return true;
} }
bool OpenMPCounterVisitor::Pre(const OpenMPConstruct &c) { bool OpenMPCounterVisitor::Pre(const OpenMPConstruct &c) {
OmpWrapperType *ow{new OmpWrapperType(&c)}; OmpWrapperType *ow{new OmpWrapperType(&c)};
ompWrapperStack.push_back(ow); ompWrapperStack.push_back(ow);
return true; return true;
} }
bool OpenMPCounterVisitor::Pre(const OmpEndLoopDirective &c) { return true; }
bool OpenMPCounterVisitor::Pre(const DoConstruct &) {
loopLogRecordStack.push_back(curLoopLogRecord);
return true;
}
void OpenMPCounterVisitor::Post(const OpenMPDeclarativeConstruct &) { void OpenMPCounterVisitor::Post(const OpenMPDeclarativeConstruct &) {
PostConstructsCommon(); PostConstructsCommon();
} }
void OpenMPCounterVisitor::Post(const OpenMPConstruct &) { void OpenMPCounterVisitor::Post(const OpenMPConstruct &) {
PostConstructsCommon(); PostConstructsCommon();
} }
void OpenMPCounterVisitor::PostConstructsCommon() { void OpenMPCounterVisitor::PostConstructsCommon() {
OmpWrapperType *curConstruct = ompWrapperStack.back(); OmpWrapperType *curConstruct = ompWrapperStack.back();
std::sort( std::sort(
clauseStrings[curConstruct].begin(), clauseStrings[curConstruct].end()); clauseStrings[curConstruct].begin(), clauseStrings[curConstruct].end());
SourcePosition s{getLocation(*curConstruct)}; SourcePosition s{getLocation(*curConstruct)};
LogRecord r{s.file.path(), s.line, getName(*curConstruct), LogRecord r{s.file.path(), s.line, getName(*curConstruct),
clauseStrings[curConstruct]}; clauseStrings[curConstruct]};
constructClauses.push_back(r); constructClauses.push_back(r);
// Keep track of loop log records if it can potentially have the
// nowait clause added on later.
if (const auto *oc = std::get_if<const OpenMPConstruct *>(curConstruct)) {
if (const auto *olc = std::get_if<OpenMPLoopConstruct>(&(*oc)->u)) {
const auto &beginLoopDir{
std::get<Fortran::parser::OmpBeginLoopDirective>(olc->t)};
const auto &beginDir{
std::get<Fortran::parser::OmpLoopDirective>(beginLoopDir.t)};
if (beginDir.v == llvm::omp::Directive::OMPD_do ||
beginDir.v == llvm::omp::Directive::OMPD_do_simd) {
curLoopLogRecord = &constructClauses.back();
}
}
}
auto it = clauseStrings.find(curConstruct); auto it = clauseStrings.find(curConstruct);
clauseStrings.erase(it); clauseStrings.erase(it);
ompWrapperStack.pop_back(); ompWrapperStack.pop_back();
delete curConstruct; delete curConstruct;
} }
void OpenMPCounterVisitor::Post(const OmpEndLoopDirective &c) {}
void OpenMPCounterVisitor::Post(const OmpProcBindClause::Type &c) { void OpenMPCounterVisitor::Post(const OmpProcBindClause::Type &c) {
clauseDetails += "type=" + OmpProcBindClause::EnumToString(c) + ";"; clauseDetails += "type=" + OmpProcBindClause::EnumToString(c) + ";";
} }
void OpenMPCounterVisitor::Post(const OmpDefaultClause::Type &c) { void OpenMPCounterVisitor::Post(const OmpDefaultClause::Type &c) {
clauseDetails += "type=" + OmpDefaultClause::EnumToString(c) + ";"; clauseDetails += "type=" + OmpDefaultClause::EnumToString(c) + ";";
} }
void OpenMPCounterVisitor::Post( void OpenMPCounterVisitor::Post(
Show All 27 Lines
void OpenMPCounterVisitor::Post(const OmpCancelType::Type &c) { void OpenMPCounterVisitor::Post(const OmpCancelType::Type &c) {
clauseDetails += "type=" + OmpCancelType::EnumToString(c) + ";"; clauseDetails += "type=" + OmpCancelType::EnumToString(c) + ";";
} }
void OpenMPCounterVisitor::Post(const OmpClause &c) { void OpenMPCounterVisitor::Post(const OmpClause &c) {
PostClauseCommon(normalize_clause_name(c.source.ToString())); PostClauseCommon(normalize_clause_name(c.source.ToString()));
clauseDetails.clear(); clauseDetails.clear();
} }
void OpenMPCounterVisitor::PostClauseCommon(const ClauseInfo &ci) { void OpenMPCounterVisitor::PostClauseCommon(const ClauseInfo &ci) {
// The end loop construct (!$omp end do) can contain a nowait clause.
// The flang parser does not parse the end loop construct as part of
// the OpenMP construct for the loop construct. So the end loop is left
// hanging as a separate executable construct. If a nowait clause is seen in
// an end loop construct we have to find the associated loop construct and
// add nowait to its list of clauses. Note: This is not a bug in flang, the
// parse tree is corrected during semantic analysis.
if (ci.clause == "nowait") {
assert(curLoopLogRecord &&
"loop Construct should be visited before a nowait clause");
curLoopLogRecord->clauses.push_back(ci);
} else {
assert(!ompWrapperStack.empty() && assert(!ompWrapperStack.empty() &&
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    assert(!ompWrapperStack.empty() &&
-        "Construct should be visited before clause");
-    clauseStrings[ompWrapperStack.back()].push_back(ci);
+  assert(
+      !ompWrapperStack.empty() && "Construct should be visited before clause");
+  clauseStrings[ompWrapperStack.back()].push_back(ci);
Lint: Pre-merge checks: clang-format: please reformat the code ``` - assert(!ompWrapperStack.empty() &&…
"Construct should be visited before clause"); "Construct should be visited before clause");
clauseStrings[ompWrapperStack.back()].push_back(ci); clauseStrings[ompWrapperStack.back()].push_back(ci);
} }
}
void OpenMPCounterVisitor::Post(const DoConstruct &) {
curLoopLogRecord = loopLogRecordStack.back();
loopLogRecordStack.pop_back();
}
} // namespace parser } // namespace parser
} // namespace Fortran } // namespace Fortran

flang/examples/flang-omp-report-plugin/flang-omp-report.cpp

//===-- examples/flang-omp-report-plugin/flang-omp-report.cpp -------------===// //===-- examples/flang-omp-report-plugin/flang-omp-report.cpp -------------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// This plugin parses a Fortran source file and generates a YAML // This plugin parses a Fortran source file and generates a YAML
Show All 19 Lines
using namespace Fortran::parser; using namespace Fortran::parser;
LLVM_YAML_IS_SEQUENCE_VECTOR(LogRecord) LLVM_YAML_IS_SEQUENCE_VECTOR(LogRecord)
LLVM_YAML_IS_SEQUENCE_VECTOR(ClauseInfo) LLVM_YAML_IS_SEQUENCE_VECTOR(ClauseInfo)
namespace llvm { namespace llvm {
namespace yaml { namespace yaml {
using llvm::yaml::IO; using llvm::yaml::IO;
using llvm::yaml::MappingTraits; using llvm::yaml::MappingTraits;
template <typename T>
struct SequenceTraits<std::deque<T>,
std::enable_if_t<CheckIsBool<SequenceElementTraits<T>::flow>::value>>
: SequenceTraitsImpl<std::deque<T>, SequenceElementTraits<T>::flow> {};
template <> struct MappingTraits<ClauseInfo> { template <> struct MappingTraits<ClauseInfo> {
static void mapping(IO &io, ClauseInfo &info) { static void mapping(IO &io, ClauseInfo &info) {
io.mapRequired("clause", info.clause); io.mapRequired("clause", info.clause);
io.mapRequired("details", info.clauseDetails); io.mapRequired("details", info.clauseDetails);
} }
}; };
template <> struct MappingTraits<LogRecord> { template <> struct MappingTraits<LogRecord> {
static void mapping(IO &io, LogRecord &info) { static void mapping(IO &io, LogRecord &info) {
Show All 32 Lines

flang/test/Examples/omp-nowait.f90

  • This file was added.
! Check the flang-omp-report plugin for omp-nowait.f90
awarzynskiUnsubmitted
Done
ReplyInline Actions

[nit] This comment doesn't add much here. Perhaps just delete?

awarzynski: [nit] This comment doesn't add much here. Perhaps just delete?
! REQUIRES: plugins, examples, shell
! RUN: %flang_fc1 -load %llvmshlibdir/flangOmpReport.so -plugin flang-omp-report -fopenmp %s -o - | FileCheck %s
! Check OpenMP 2.13.6 atomic Construct
awarzynskiUnsubmitted
Done
ReplyInline Actions

Not true ;-)

awarzynski: Not true ;-)
subroutine sb(n)
implicit none
integer :: n
integer :: arr(n,n), brr(n,n), crr(n,n)
integer :: arr_single(n),arr_quad(n,n,n,n)
integer :: i,j,k,l,tmp,tmp1,tmp2
! CHECK:---
!Simple check with nowait
!$omp do
do i = 1, n
arr_single(i) = i
end do
!$omp end do nowait
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-6]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
!Check for no effects on loop without nowait
!$omp do
do i = 1, n
arr_single(i) = i
end do
!$omp end do
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-6]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses: []
!Check with another construct nested inside loop with nowait
!$omp parallel shared(arr)
!$omp do
do i = 1, n
!$omp critical
arr_single(i) = i
!$omp end critical
end do
!$omp end do nowait
!$omp end parallel
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-7]]
! CHECK-NEXT: construct: critical
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-13]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-20]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: shared
! CHECK-NEXT: details: arr
!Check with back to back loops (one with nowait) inside a parallel construct
!$omp parallel shared(arr)
!$omp do
do i=1,10
arr(i,j) = i+j
end do
!$omp end do nowait
!$omp do schedule(guided)
do j=1,10
end do
!$omp end do
!$omp end parallel
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-11]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-12]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: schedule
! CHECK-NEXT: details: guided
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-24]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: shared
! CHECK-NEXT: details: arr
!Check nested parallel do loops with a nowait outside
!$omp parallel shared(arr)
!$omp do
do i=1,10
arr_single(i)=i
!$omp parallel
!$omp do
do j=1,10
!$omp critical
arr(i,j) = i+j
!$omp end critical
end do
!$omp end do
!$omp end parallel
end do
!$omp end do nowait
!$omp end parallel
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-10]]
! CHECK-NEXT: construct: critical
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-16]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-21]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-28]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-35]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: shared
! CHECK-NEXT: details: arr
!Check nested parallel do loops with a nowait inside
!$omp parallel shared(arr)
!$omp do
do i=1,10
arr_single(i)=i
!$omp parallel
!$omp do
do j=1,10
!$omp critical
arr(i,j) = i+j
!$omp end critical
end do
!$omp end do nowait
!$omp end parallel
end do
!$omp end do
!$omp end parallel
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-10]]
! CHECK-NEXT: construct: critical
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-16]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-23]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-30]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-35]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: shared
! CHECK-NEXT: details: arr
!Check nested parallel do loops with a nowait inside
!$omp parallel
!$omp do
do i=1,10
arr_single(i)=i
!$omp parallel shared(arr_quad)
!$omp do schedule(dynamic)
do j=1,10
!$omp parallel
!$omp do
do k=1,10
!$omp parallel
!$omp do
do l=1,10
arr_quad(i,j,k,l) = i+j+k+l
end do
!$omp end do nowait
!$omp end parallel
end do
!$omp end do
!$omp end parallel
end do
!$omp end do nowait
!$omp end parallel
end do
!$omp end do
!$omp end parallel
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-16]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-23]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-29]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-34]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-40]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT: - clause: schedule
! CHECK-NEXT: details: dynamic
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-49]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: shared
! CHECK-NEXT: details: arr_quad
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-58]]
! CHECK-NEXT: construct: do
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-63]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses: []
!Check a do simd with nowait
!$omp do simd private(tmp)
do j = 1,n
do i = 1,n
tmp = arr(i,j) + brr(i,j)
crr(i,j) = tmp
end do
end do
!$omp end do simd nowait
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-9]]
! CHECK-NEXT: construct: do simd
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT: - clause: private
! CHECK-NEXT: details: tmp
!test nowait on non-do construct
!$omp parallel
!$omp single
tmp1 = i+j
!$omp end single
!$omp single
tmp2 = i-j
!$omp end single nowait
!$omp end parallel
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-9]]
! CHECK-NEXT: construct: single
! CHECK-NEXT: clauses: []
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-9]]
! CHECK-NEXT: construct: single
! CHECK-NEXT: clauses:
! CHECK-NEXT: - clause: nowait
! CHECK-NEXT: details: ''
! CHECK-NEXT:- file: '{{[^"]*}}omp-nowait.f90'
! CHECK-NEXT: line: [[@LINE-20]]
! CHECK-NEXT: construct: parallel
! CHECK-NEXT: clauses: []
end subroutine
! CHECK-NEXT:...