Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Patched up the call sites that are straightforward. There are ~4 calls in SemaOpenMP where an !isValueDependent() could be dropped if it is safe to call PerformContextualImplicitConversion on such a value, which it probably is, but it's hard to be certain. There are a few places where Diag() calls would be changed by dropping the call, those are also left unchanged here.
clang/lib/Sema/SemaExprCXX.cpp | ||
---|---|---|
2137 ↗ | (On Diff #381040) | Shame about the whitespace noise. getIntegerConstantExpr guards the block and is dominated by isValueDependent. |
clang/lib/Sema/SemaTemplateDeduction.cpp | ||
2171 ↗ | (On Diff #381040) | this parses as !ArgExpr->isValueDependent() && ArgExpr->getIntegerConstantExpr(S.Context) && ... |
Comment Actions
I checked the call sites to see if any were missed and I did not spot uses that should also be changed. LGTM, thanks!