This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM
ClosedPublic

Authored by mgorny on Oct 19 2021, 5:20 AM.

Details

Summary

Fix incorrect values for value_regs, and incomplete values for
invalidate_regs in RegisterInfos_arm. The value_regs entry needs
to list only one base (i.e. larger) register that needs to be read
to get the value for this register, while invalidate_regs needs to list
all other registers (including pseudo-register) whose values would
change when this register is written to.

While at it, introduce helper macros for the definitions.

Diff Detail

Event Timeline

mgorny created this revision.Oct 19 2021, 5:20 AM
labath accepted this revision.Oct 19 2021, 5:28 AM
labath added a reviewer: omjavaid.

rG7a8ba4ffbee fixed a similar problem on aarch64.

This revision is now accepted and ready to land.Oct 19 2021, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2021, 5:47 AM