Page MenuHomePhabricator

[OpenMP][libomp] Allow users to specify KMP_HW_SUBSET in any order
ClosedPublic

Authored by jlpeyton on Oct 18 2021, 12:29 PM.

Details

Summary

Remove restriction forcing users to specify the KMP_HW_SUBSET value in
topology order. This patch sorts the user KMP_HW_SUBSET value before
trying to apply it. For example: 1s,4c,2t is equivalent to 2t,1s,4c

Diff Detail

Event Timeline

jlpeyton created this revision.Oct 18 2021, 12:29 PM
jlpeyton requested review of this revision.Oct 18 2021, 12:29 PM
ye-luo added a subscriber: ye-luo.EditedOct 18 2021, 1:55 PM

Can we have user documentation for KMP_XX environment variables on https://openmp.llvm.org//design/Runtimes.html#openmp-runtimes?

Can we have user documentation for KMP_XX environment variables on https://openmp.llvm.org//design/Runtimes.html#openmp-runtimes?

We're trying to figure out if we can use the text from https://www.intel.com/content/www/us/en/develop/documentation/oneapi-dpcpp-cpp-compiler-dev-guide-and-reference/top/compilation/supported-environment-variables.html instead of re-doing the definitions in two separate places.

AndreyChurbanov accepted this revision.Nov 17 2021, 7:49 AM

LGTM

The problem with absent documentation can be addressed in a separate patch I think.

This revision is now accepted and ready to land.Nov 17 2021, 7:49 AM