[mlir][python] Add nameloc getter

[jpienaar]

Summary

Expose the nameloc getter to Python API.

[ftynse]

mlir/lib/Bindings/Python/IRCore.cpp

1989

Nit: maybe using childLoc ? childLoc->get() : mlirLocationUnknownGet(context->get()) as the last argument for mlirLocationNameGet would make this more concise.

mlir/lib/Bindings/Python/IRCore.cpp

 Returns a Type object or raises a ValueError if the type cannot be parsed.
 
 See also: https://mlir.llvm.org/docs/LangRef/#type-system
 )";
 
 static const char kContextGetFileLocationDocstring[] =
     R"(Gets a Location representing a file, line and column)";
 
+static const char kContextGetNameLocationDocString[] =
+    R"(Gets a Location representing a named location with optional child location)";
+
 static const char kModuleParseDocstring[] =
     R"(Parses a module's assembly format from a string.
 
 Returns a new MlirModule or raises a ValueError if the parsing fails.
 
 See also: https://mlir.llvm.org/docs/LangRef/
 )";
 
py::class_<PyLocation>(m, "Location", py::module_local())
              DefaultingPyMlirContext context) {
             return PyLocation(
                 context->getRef(),
                 mlirLocationFileLineColGet(
                     context->get(), toMlirStringRef(filename), line, col));
           },
           py::arg("filename"), py::arg("line"), py::arg("col"),
           py::arg("context") = py::none(), kContextGetFileLocationDocstring)
+      .def_static(
+          "name",
+          [](std::string name, llvm::Optional<PyLocation> childLoc,
+             DefaultingPyMlirContext context) {
+            return PyLocation(
+                context->getRef(),
+                mlirLocationNameGet(
+                    context->get(), toMlirStringRef(name),
+                    childLoc ? childLoc->get()
+                             : mlirLocationUnknownGet(context->get())));
+          },
+          py::arg("name"), py::arg("childLoc") = py::none(),
+          py::arg("context") = py::none(), kContextGetNameLocationDocString)
       .def_property_readonly(
           "context",
           [](PyLocation &self) { return self.getContext().getObject(); },
           "Context that owns the Location")
       .def("__repr__", [](PyLocation &self) {
         PyPrintAccumulator printAccum;
         mlirLocationPrint(self, printAccum.getCallback(),
                           printAccum.getUserData());
         return printAccum.join();

mlir/test/python/ir/location.py

def testFileLineCol():
   # CHECK: file str: loc("foo.txt":123:56)
   print("file str:", str(loc))
   # CHECK: file repr: loc("foo.txt":123:56)
   print("file repr:", repr(loc))
 
 run(testFileLineCol)
 
 
+# CHECK-LABEL: TEST: testName
+def testName():
+  with Context() as ctx:
+    loc = Location.name("nombre")
+    locWithChildLoc = Location.name("naam", loc)
+  ctx = None
+  gc.collect()
+  # CHECK: file str: loc("nombre")
+  print("file str:", str(loc))
+  # CHECK: file repr: loc("nombre")
+  print("file repr:", repr(loc))
+  # CHECK: file str: loc("naam"("nombre"))
+  print("file str:", str(locWithChildLoc))
+  # CHECK: file repr: loc("naam"("nombre"))
+  print("file repr:", repr(locWithChildLoc))
+
+run(testName)
+
+
 # CHECK-LABEL: TEST: testLocationCapsule
 def testLocationCapsule():
   with Context() as ctx:
     loc1 = Location.file("foo.txt", 123, 56)
   # CHECK: mlir.ir.Location._CAPIPtr
   loc_capsule = loc1._CAPIPtr
   print(loc_capsule)
   loc2 = Location._CAPICreate(loc_capsule)
   assert loc2 == loc1
   assert loc2.context is ctx
 
 run(testLocationCapsule)