This is an archive of the discontinued LLVM Phabricator instance.

Differential D111597

[RISCV][Clang] Fix RISCV vector header comment.
ClosedPublic

Authored by jacquesguan on Oct 11 2021, 6:58 PM.

Details

Reviewers
HsiangKai
khchen
craig.topper
Commits
rG477f5f4fca2b: [RISCV][Clang] Fix RISCV vector header comment.
Summary

Fix wrong comment for macro endif.

Diff Detail

Event Timeline

jacquesguan created this revision.Oct 11 2021, 6:58 PM
Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck and 25 others. · View Herald TranscriptOct 11 2021, 6:58 PM
jacquesguan requested review of this revision.Oct 11 2021, 6:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 11 2021, 6:58 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B128249: Diff 378853.Oct 11 2021, 7:23 PM
khchen accepted this revision.Oct 12 2021, 1:23 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Oct 12 2021, 1:23 AM
This revision was landed with ongoing or failed builds.Oct 12 2021, 3:26 AM
Closed by commit rG477f5f4fca2b: [RISCV][Clang] Fix RISCV vector header comment. (authored by jacquesguan, committed by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rG477f5f4fca2b: [RISCV][Clang] Fix RISCV vector header comment..

Revision Contents

PathSize
clang/
utils/
TableGen/
2 lines

Diff 378853

clang/utils/TableGen/RISCVVEmitter.cpp

Show First 20 Lines • Show All 1,029 Lines • ▼ Show 20 Lines emitArchMacroAndBody(Defs, OS, [](raw_ostream &OS, const RVVIntrinsic &Inst) {
if (!Inst.isMask() && !Inst.hasNoMaskedOverloaded()) if (!Inst.isMask() && !Inst.hasNoMaskedOverloaded())
return; return;
OS << "__rvv_overloaded "; OS << "__rvv_overloaded ";
Inst.emitMangledFuncDef(OS); Inst.emitMangledFuncDef(OS);
}); });
OS << "\n#ifdef __cplusplus\n"; OS << "\n#ifdef __cplusplus\n";
OS << "}\n"; OS << "}\n";
OS << "#endif // __riscv_vector\n"; OS << "#endif // __cplusplus\n";
OS << "#endif // __RISCV_VECTOR_H\n"; OS << "#endif // __RISCV_VECTOR_H\n";
} }
void RVVEmitter::createBuiltins(raw_ostream &OS) { void RVVEmitter::createBuiltins(raw_ostream &OS) {
std::vector<std::unique_ptr<RVVIntrinsic>> Defs; std::vector<std::unique_ptr<RVVIntrinsic>> Defs;
createRVVIntrinsics(Defs); createRVVIntrinsics(Defs);
OS << "#if defined(TARGET_BUILTIN) && !defined(RISCVV_BUILTIN)\n"; OS << "#if defined(TARGET_BUILTIN) && !defined(RISCVV_BUILTIN)\n";
▲ Show 20 Lines • Show All 275 Lines • Show Last 20 Lines