Until now, we only had documentation oriented towards developers of the
bindings. Provide some documentation for users of the bindings that don't want
or need to understand the inner workings.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Address review.
mlir/docs/Bindings/Python.md | ||
---|---|---|
538 | I'd say this is the way to do dyn_cast. For isa, it should be possible to call OpResult.isinstance(value) similarly to types, but somebody needs to add it. |
mlir/docs/Bindings/Python.md | ||
---|---|---|
362 | Remove "maintain it" | |
477 | s/does not have/is not of/ | |
516 | Since people always ask, maybe note that by convention, Attribute subclasses provide a static get method (or close variant like get_signless for cases when an attribute can be identified in different ways) used to get a uniqued instance from the context. |
Fixed in 90a6c3c2e4d91ba081e553d7fe33c89ceacc9e4a.
mlir/docs/Bindings/Python.md | ||
---|---|---|
516 | It's written below in the "creating IR objects / attributes and types" section. |
typo