This is an archive of the discontinued LLVM Phabricator instance.

[APFloat] Set size of PPCDoubleDouble to 128
ClosedPublic

Authored by qiucf on Oct 8 2021, 3:17 AM.

Details

Summary

Commit 566690b0 uses size information in float semantics, but PPCDoubleDouble left them empty.

As follow-up, we can consider remove PPCDoubleDoubleLegacy and fill other fields in the future.

Diff Detail

Event Timeline

qiucf created this revision.Oct 8 2021, 3:17 AM
qiucf requested review of this revision.Oct 8 2021, 3:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2021, 3:17 AM
foad accepted this revision.Oct 8 2021, 3:31 AM

LGTM. I didn't see any breakage from my patch so I guess ppcf128_ones_store is a new test?

This revision is now accepted and ready to land.Oct 8 2021, 3:31 AM
qiucf added a comment.Oct 8 2021, 7:12 PM

I didn't see any breakage from my patch so I guess ppcf128_ones_store is a new test?

Yes, I added that by a staged diff :-)

This revision was landed with ongoing or failed builds.Oct 8 2021, 7:14 PM
This revision was automatically updated to reflect the committed changes.