After CMake 3.18, we are able to limit the scope of the
find_package(Python3 ...) search to just Development.Module. Searching
for Development will fail in manylinux builds, and isn't necessary
since we are not embedding the Python interpreter. For more information, see:
https://pybind11.readthedocs.io/en/stable/compiling.html#findpython-mode
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice find!! We should propagate this to downstreams (at least a couple of which already require this version of cmake and don't need the conditional).
Comment Actions
I will take care of doing this for CIRCT, and tagged Sean for visibility on Torch MLIR.
Comment Actions
Sorry I had to revert, this broke the build here: https://lab.llvm.org/buildbot/#/builders/61/builds/15842
Comment Actions
Thanks Mehdi. I will take a look at that. We also had some issues downstream so I was planning to revert but you beat me to it.