This is an archive of the discontinued LLVM Phabricator instance.

[UnknownProvenance] Add llvm-c support

Authored by jeroen.dobbelaere on Oct 5 2021, 8:09 AM.



llvm-c support for UnknownProvenance.

Diff Detail

Event Timeline

jeroen.dobbelaere requested review of this revision.Oct 5 2021, 8:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2021, 8:09 AM
deadalnix requested changes to this revision.Oct 13 2021, 3:11 AM
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.

This is great that you though of updating the echo test.

The echo test is a test that read some IR, and then spit it back out, using the C API. There are some files containing LLVM IR that contain various pieces of IR that are run through he echo tool. This ensure that the IR is read and then regenerated properly through the C API.

It would be great if you could either modify an existing test or add a new one so that the unknown provenance construct is exercised by the C API - which in turn will prove that this code works as expected.

This revision now requires changes to proceed.Oct 13 2021, 3:11 AM

Could you point me to a test that is using this 'echo' ? It is possible that I can only add the test itself once D104268, D104269 and D104270 are added.