Page MenuHomePhabricator
Differential D110974

Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD"
ClosedPublic
Actions

Authored by drodriguez on Oct 1 2021, 2:34 PM.

Details

Reviewers
alexander-shaposhnikov
nuriamari
int3
gkm
thakis
Group Reviewers
Restricted Project
Commits
rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD"
Summary

This reverts commit cc8229603b67763e77a46894f88f7d3ddd04de34.

As discussed in the review of https://reviews.llvm.org/D109972, this was not
right approach, so we are reverting to start with a different approach.

Diff Detail

Event Timeline

drodriguez created this revision.Oct 1 2021, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2021, 2:34 PM
Herald added subscribers: hiraditya, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B126747: Diff 376638.Oct 1 2021, 2:34 PM
drodriguez requested review of this revision.Oct 1 2021, 2:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2021, 2:34 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
drodriguez mentioned this in D109972: Regenerate LC_CODE_SIGNATURE during llvm-objcopy operations.Oct 1 2021, 2:35 PM
drodriguez mentioned this in D109803: Extract LC_CODE_SIGNATURE related implementation out of LLD.
thakis accepted this revision.Oct 1 2021, 3:34 PM
thakis added a subscriber: thakis.

LGTM

This revision is now accepted and ready to land.Oct 1 2021, 3:34 PM
Closed by commit rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD" (authored by drodriguez). · Explain WhyOct 1 2021, 5:21 PM
This revision was automatically updated to reflect the committed changes.
drodriguez added a commit: rG657f02d45804: Revert "Extract LC_CODE_SIGNATURE related implementation out of LLD".

Revision Contents
Changeset List

PathSize
lld/
MachO/
18 lines
96 lines
llvm/
include/
llvm/
Object/
38 lines
lib/
Object/
1 line

Diff 376655

View Options

lld/MachO/SyntheticSections.h

Loading...
View Options

lld/MachO/SyntheticSections.cpp

Loading...
View Options

llvm/include/llvm/Object/MachO.h

Loading...
View Options

llvm/lib/Object/CMakeLists.txt

Loading...
View Options

llvm/lib/Object/CodeSignatureSection.cpp

Loading...