MLIR can't support -Bsymbolic link option, fail at CMake time with a helpful message instead of broken runtime

[mehdi_amini]

Update regex to not flag Bsymbolic-functions

[jpienaar]

mlir/CMakeLists.txt

43

OOC why `, instead of just `?

[mehdi_amini]

mlir/CMakeLists.txt

43

Bad copy paste :)

[mehdi_amini]

Remove spurious comma in the comment

[MaskRay]

Ugh, I thought such check is not necessary. It is difficult to enumerate every incorrect configuration users may use.. -Bsymbolic isn't very common anyway.

[mehdi_amini]

In D110483#3022714, @MaskRay wrote:

Ugh, I thought such check is not necessary. It is difficult to enumerate every incorrect configuration users may use.. -Bsymbolic isn't very common anyway.

The thing is that we don't need to enumerate every potential configuration, we can just assert things for which we get bug reports :)
It seems to me like a cheap cost to save some users some pain.

mlir/CMakeLists.txt

 set(MLIR_BINARY_DIR  ${CMAKE_CURRENT_BINARY_DIR})
 set(MLIR_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR}/include)
 set(MLIR_TOOLS_DIR   ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
 
 include(AddMLIR)
 
+# -BSymbolic is incompatible with TypeID
+if("${CMAKE_SHARED_LINKER_FLAGS}" MATCHES "-Bsymbolic[^-]")
+  message(FATAL_ERROR " MLIR does not support `-Bsymbolic` (see http://llvm.org/pr51420 ),"
+          " try `,-Bsymbolic-functions` instead.")
+endif()
+
 # Forbid implicit function declaration: this may lead to subtle bugs and we
 # don't have a reason to support this.
 check_c_compiler_flag("-Werror=implicit-function-declaration" C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION)
 append_if(C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION "-Werror=implicit-function-declaration" CMAKE_C_FLAGS)
 
 # Installing the headers and docs needs to depend on generating any public
 # tablegen'd targets.
 # mlir-generic-headers are dialect-independent.