Page MenuHomePhabricator

MLIR can't support -Bsymbolic link option, fail at CMake time with a helpful message instead of broken runtime
ClosedPublic

Authored by mehdi_amini on Sep 25 2021, 10:25 AM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Sep 25 2021, 10:25 AM
mehdi_amini requested review of this revision.Sep 25 2021, 10:25 AM

Update regex to not flag Bsymbolic-functions

jpienaar added inline comments.
mlir/CMakeLists.txt
43

OOC why `, instead of just `?

mehdi_amini added inline comments.Sep 25 2021, 1:43 PM
mlir/CMakeLists.txt
43

Bad copy paste :)

Remove spurious comma in the comment

mehdi_amini marked an inline comment as done.Sep 25 2021, 1:55 PM

Ugh, I thought such check is not necessary. It is difficult to enumerate every incorrect configuration users may use.. -Bsymbolic isn't very common anyway.

Ugh, I thought such check is not necessary. It is difficult to enumerate every incorrect configuration users may use.. -Bsymbolic isn't very common anyway.

The thing is that we don't need to enumerate every potential configuration, we can just assert things for which we get bug reports :)
It seems to me like a cheap cost to save some users some pain.

MaskRay accepted this revision.Sep 25 2021, 5:02 PM
This revision is now accepted and ready to land.Sep 25 2021, 5:02 PM