This is an archive of the discontinued LLVM Phabricator instance.

Differential D110323

[fir][NFC] rename canBePointerOrHeapElementType to cannotBePointerOrHeapElementType
ClosedPublic

Authored by clementval on Sep 23 2021, 5:30 AM.

Details

Reviewers
jeanPerier
svedanayagam
sscalpone
kiranchandramohan
jdoerfert
schweitz
Commits
rGbbc74a11bc15: [fir][NFC] rename canBePointerOrHeapElementType to…
Summary

This patch is part of the upstreaming effort from fir-dev branch.
Rename the function so the name conveys better what it does.

Co-authored-by: schweitz
Co-authored-by: jeanPerier

Diff Detail

Event Timeline

clementval created this revision.Sep 23 2021, 5:30 AM
Herald added a subscriber: mehdi_amini. · View Herald TranscriptSep 23 2021, 5:30 AM
clementval requested review of this revision.Sep 23 2021, 5:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2021, 5:30 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B125323: Diff 374514.Sep 23 2021, 5:42 AM
clementval edited the summary of this revision. (Show Details)Sep 23 2021, 6:11 AM
clementval added a project: Restricted Project.
jeanPerier accepted this revision.Sep 23 2021, 8:17 AM
This revision is now accepted and ready to land.Sep 23 2021, 8:17 AM
Closed by commit rGbbc74a11bc15: [fir][NFC] rename canBePointerOrHeapElementType to… (authored by clementval). · Explain WhySep 23 2021, 9:50 AM
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rGbbc74a11bc15: [fir][NFC] rename canBePointerOrHeapElementType to….

Revision Contents

PathSize
flang/
lib/
Optimizer/
Dialect/
6 lines

Diff 374514

flang/lib/Optimizer/Dialect/FIRType.cpp

Show First 20 Lines • Show All 294 Lines • ▼ Show 20 LinesBoxProcType::verify(llvm::function_ref<mlir::InFlightDiagnostic()> emitError,
if (eleTy.isa<mlir::FunctionType>()) if (eleTy.isa<mlir::FunctionType>())
return mlir::success(); return mlir::success();
if (auto refTy = eleTy.dyn_cast<ReferenceType>()) if (auto refTy = eleTy.dyn_cast<ReferenceType>())
if (refTy.isa<mlir::FunctionType>()) if (refTy.isa<mlir::FunctionType>())
return mlir::success(); return mlir::success();
return emitError() << "invalid type for boxproc" << eleTy << '\n'; return emitError() << "invalid type for boxproc" << eleTy << '\n';
} }
static bool canBePointerOrHeapElementType(mlir::Type eleTy) { static bool cannotBePointerOrHeapElementType(mlir::Type eleTy) {
return eleTy.isa<BoxType, BoxCharType, BoxProcType, ShapeType, ShapeShiftType, return eleTy.isa<BoxType, BoxCharType, BoxProcType, ShapeType, ShapeShiftType,
SliceType, FieldType, LenType, HeapType, PointerType, SliceType, FieldType, LenType, HeapType, PointerType,
ReferenceType, TypeDescType>(); ReferenceType, TypeDescType>();
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// BoxType // BoxType
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 119 Lines • ▼ Show 20 Lines
void fir::HeapType::print(mlir::DialectAsmPrinter &printer) const { void fir::HeapType::print(mlir::DialectAsmPrinter &printer) const {
printer << getMnemonic() << "<" << getEleTy() << '>'; printer << getMnemonic() << "<" << getEleTy() << '>';
} }
mlir::LogicalResult mlir::LogicalResult
fir::HeapType::verify(llvm::function_ref<mlir::InFlightDiagnostic()> emitError, fir::HeapType::verify(llvm::function_ref<mlir::InFlightDiagnostic()> emitError,
mlir::Type eleTy) { mlir::Type eleTy) {
if (canBePointerOrHeapElementType(eleTy)) if (cannotBePointerOrHeapElementType(eleTy))
return emitError() << "cannot build a heap pointer to type: " << eleTy return emitError() << "cannot build a heap pointer to type: " << eleTy
<< '\n'; << '\n';
return mlir::success(); return mlir::success();
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// IntegerType // IntegerType
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
Show All 34 Lines
void fir::PointerType::print(mlir::DialectAsmPrinter &printer) const { void fir::PointerType::print(mlir::DialectAsmPrinter &printer) const {
printer << getMnemonic() << "<" << getEleTy() << '>'; printer << getMnemonic() << "<" << getEleTy() << '>';
} }
mlir::LogicalResult fir::PointerType::verify( mlir::LogicalResult fir::PointerType::verify(
llvm::function_ref<mlir::InFlightDiagnostic()> emitError, llvm::function_ref<mlir::InFlightDiagnostic()> emitError,
mlir::Type eleTy) { mlir::Type eleTy) {
if (canBePointerOrHeapElementType(eleTy)) if (cannotBePointerOrHeapElementType(eleTy))
return emitError() << "cannot build a pointer to type: " << eleTy << '\n'; return emitError() << "cannot build a pointer to type: " << eleTy << '\n';
return mlir::success(); return mlir::success();
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// RealType // RealType
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 383 Lines • Show Last 20 Lines