Now not just SUM, but also PRODUCT, AND, OR, XOR. The reductions
MIN and MAX are still to be done (also depends on recognizing
these operations in cmp-select constructs).
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
---|---|---|
316 | All cases are indeed covered, but some sanitizer/linters like having this anyway (at least at one point, Mehdi, is this still the case?) | |
367–370 | For And, you will need "-1", not "1" to have all bits set. kOr could indeed share the kAdd. |
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp | ||
---|---|---|
367–370 | I think I was wrong with kAnd, it will need -1|...-1|r, not 1...1|r |
This shouldn't be needed. Right?