Page MenuHomePhabricator

[OpenMP] Declare variants for templates need to match # template args
AcceptedPublic

Authored by jdoerfert on Sep 14 2021, 9:30 AM.

Details

Summary

A declare variant template is only compatible with a base when the
number of template arguments is equal, otherwise our instantiations will
produce nonsensical results.

Exposes as part of D109344.

Diff Detail

Unit TestsFailed

TimeTest
140 msx64 debian > Clang Tools.clang-tidy/checkers::readability-container-data-pointer.cpp
Script: -- : 'RUN: at line 1'; /usr/bin/python3.9 /var/lib/buildkite-agent/builds/llvm-project/clang-tools-extra/test/../test/clang-tidy/check_clang_tidy.py /var/lib/buildkite-agent/builds/llvm-project/clang-tools-extra/test/clang-tidy/checkers/readability-container-data-pointer.cpp readability-container-data-pointer /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/tools/extra/test/clang-tidy/checkers/Output/readability-container-data-pointer.cpp.tmp

Event Timeline

jdoerfert created this revision.Sep 14 2021, 9:30 AM
jdoerfert requested review of this revision.Sep 14 2021, 9:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2021, 9:30 AM
JonChesterfield accepted this revision.Sep 14 2021, 9:32 AM

Ah, nice! Thanks for the fix

This revision is now accepted and ready to land.Sep 14 2021, 9:32 AM