Review comments addressed.

Reopening this. This version is supposed to fix the buildbot failures on PPC machines.
Since I don't have PPC machine I am not sure if this will work. But the logic
followed here is motivated from Clang :: Driver/program-path-priority.c, so hopefully
it will pass the CI.

I've reverted this from main for now as there seems to be issue with executing test script on some CI machines.

Rebase and review comments

Fix permissions

Added tests for the failing cases

• Addressed review comments.

• Addressed review comments
• Added LIT test case

Addressed review comments.

Working on tests.

The general problem seems bit more involved. I am not that familiar with how other architectures/systems handle the library/include path. Simplest solution that I can propose right now is to generalise my revision to other architectures for header lookup and similarly for library lookup in case of openmp. If there is better solution available please let me know I will be happy to implement it.

I was not aware that it was a general problem. I will check if I could get a general solution.

Fix comments.

• Revert the unsigned case to use Masks.
• Simplified the logic for widenScalar

Removed assert. Now WideTy overflow check is only done when WideTy is not sufficient enough.
Added test case for s24 to verify the logic.

Use SHRL for unsigned case.

Ping!

Rebase & Review comments

Add extra llc step to produce assembly in the linker.

So, neither emit-llvm-bc or emit-llvm work well with save-temps. Therefore, I feel the current approach is still valid. This does not impact nvptx or any other target in any way. And I don't see how.

Here's a bit of background,
OffloadingPrefix was not getting properly set in the dependent actions of OffloadWrapperJobAction (which are backend [11] and assemble [12]). Since backend [11] and assemble [12] host-wrapper actions have same logic to the other host actions (3 & 4), those will overwrite the previous generated files from host-only actions.

Looks good to me. Thanks!

Fixed the assert.

It is because of how addClangTargetOptions is invoked. In case of save-temps, it is being invoked for all the actions resulting in target cc1 call. That's why all these invocations have -emit-llvm-bc. I guess we need Action as an argument to addClangTargetOptions.

emit-llvm-bc does not correctly solve the problem. It works because [input, compile, assemble, backend] actions collapse to a single action by driver. This single command handles emit-llvm-bc properly. But when save-temps is specified, this collapsing does not happen which messes up command line flags of the jobs and hence the output, for e.g., preprocessor command also has -emit-llvm-bc.

This does fixes the save-temps but only when -o is not specified. If -o is specified (along with -save-temps), the name of host object file and host-wrapper object file (second last phase) is same, which fails the linker. This does not seem to be related to this patch.

Addressed review comments.

Can you use -check-prefixes=GCN,GFX8 and GCN,GFX9 so that update_mir_test_checks will common up the identical ones?

It does not work. Script warns as WARNING: Ignoring common prefixes: {'GCN'}: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-umulo.mir

Addressed review comments.

I have removed libomptarget-device-bc-path and have added amdgcn one. For diagnostic,
instead of having one per architecture, I have used the same and added second
parameter to err_drv_omp_offload_target_missingbcruntime for having arch specifc message.

LGTM. Thanks!

LGTM, thanks for fixing it.

• Added check for nogpulib
• Fixed diagnostic message

Addressed review comments.

Missed some changes,

• Fix openmp-offload.c test failure
• Fix amdgpu-openmp-toolchain.c test failure

Ping!

• Use 0 for default -O option
• Rename addOptLevelArgs to addLLCOptArg

After addressing the review comments, I have internally verified changes on few simple test programs. They seem to be working fine.

Addressed review comments.

• Combined the toolchain creation logic for nvptx and amdgcn
• Replaced -Xopenmp-target with -emit-llvm-bc inside AMDGPUOpenMP.cpp
• Removed opt from pipeline

• Scalarize the vectors first
• Using widened operation for smaller types

Ping!

Hi, apologies for late reply as I got sidetracked to some other work.

• Moved common methods of HIP and OpenMP to base AMDGPUToolChain
• Removed unnecessary asserts

Fixed failing debian tests

Won't this just prevent us from building clang due to the missing cmake changes?

It compiles and builds fine, however, I wasn't actually aware such sanity checking being present. It turns out
the unknown files inside llvm/ will lead cmake to report error but such reporting will not happen inside clang. Maybe such checks
were not enabled inside clang. Anyways thanks for pointing out. I will keep that in mind in future.

Fix clang-tidy error

Moved ops close to ADDO

Removed global-isel-abort=0

Update AMDGPU barrier intrinsic

Ping!

Looks good, thanks.