Page MenuHomePhabricator

pdhaliwal (Pushpinder Singh)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2020, 6:41 PM (21 w, 3 d)

Recent Activity

Thu, Sep 17

pdhaliwal added inline comments to D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.
Thu, Sep 17, 9:25 PM · Restricted Project
pdhaliwal updated the diff for D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.

Updated tests and clamping number of elements to 2

Thu, Sep 17, 4:31 AM · Restricted Project

Mon, Sep 7

pdhaliwal committed rG7634c64b6121: [OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE (authored by pdhaliwal).
[OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE
Mon, Sep 7, 2:15 AM
pdhaliwal closed D87084: [OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE.
Mon, Sep 7, 2:15 AM · Restricted Project

Thu, Sep 3

pdhaliwal updated the diff for D87084: [OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE.

Updated data_sharing_stack_init_common

Thu, Sep 3, 10:51 PM · Restricted Project
pdhaliwal added a comment to D87084: [OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE.

Only places where it was accessed are here and here. Jon's observation is correct. The maximum number of threads on both amdgcn and nvptx is 1024. However, on amdgcn, wave size is 64 and so maximum number of waves can be 16 and on nvptx, the warp size is 32 and maximum number of warps is 32.

Thu, Sep 3, 6:51 PM · Restricted Project
pdhaliwal requested review of D87084: [OpenMP][AMDGPU] Use DS_Max_Warp_Number instead of WARPSIZE.
Thu, Sep 3, 5:10 AM · Restricted Project

Wed, Sep 2

pdhaliwal added a comment to D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.

@arsenm , let me know if it is good to land.

Wed, Sep 2, 2:39 AM · Restricted Project

Sun, Aug 30

pdhaliwal updated the diff for D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.

Updated review comments.

Sun, Aug 30, 9:10 PM · Restricted Project

Aug 11 2020

pdhaliwal added inline comments to D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.
Aug 11 2020, 8:45 AM · Restricted Project
pdhaliwal updated the diff for D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.

Added support for vector types.

Aug 11 2020, 8:45 AM · Restricted Project
pdhaliwal retitled D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH from [GlobalISel] widenScalar G_SMULH/G_UMULH to [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.
Aug 11 2020, 5:18 AM · Restricted Project

Aug 10 2020

pdhaliwal added inline comments to D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.
Aug 10 2020, 11:41 PM · Restricted Project
pdhaliwal updated the diff for D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.

Review comments

Aug 10 2020, 11:40 PM · Restricted Project
pdhaliwal updated the diff for D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.

removed unneeded changes

Aug 10 2020, 7:15 AM · Restricted Project
pdhaliwal requested review of D85653: [GlobalISel][AMDGPU] Lower G_SMULH/G_UMULH.
Aug 10 2020, 7:09 AM · Restricted Project

Jul 29 2020

pdhaliwal committed rGc970bb5b34c1: [CMAKE] Fix 'clean' target not working (authored by pdhaliwal).
[CMAKE] Fix 'clean' target not working
Jul 29 2020, 4:34 AM
pdhaliwal closed D82847: [CMAKE] Fix 'clean' target not working.
Jul 29 2020, 4:34 AM · Restricted Project

Jul 21 2020

pdhaliwal committed rGa1b12a934d99: [OpenMP] Add missing RUN lines for OpenMP 4.5 (authored by pdhaliwal).
[OpenMP] Add missing RUN lines for OpenMP 4.5
Jul 21 2020, 10:08 PM
pdhaliwal closed D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5.
Jul 21 2020, 10:08 PM · Restricted Project
pdhaliwal updated the diff for D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5.

Added runRUN lines with OpenMP 5.0 version option

Jul 21 2020, 2:11 AM · Restricted Project

Jul 20 2020

Herald added a project to D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5: Restricted Project.
Jul 20 2020, 11:09 PM · Restricted Project

Jul 13 2020

pdhaliwal added a comment to D82847: [CMAKE] Fix 'clean' target not working.

@phosek Let me know if this is good to land.

Jul 13 2020, 4:38 AM · Restricted Project

Jul 2 2020

pdhaliwal added a comment to D81991: [AMDGPU] Control num waves per EU for implicit work-group size.

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (--date=now is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))

llvm/utils/git/pre-push.py can validate the message does not include unneeded tags.

Jul 2 2020, 4:15 AM · Restricted Project

Jul 1 2020

pdhaliwal committed rGe1a31f52cd79: [AMDGPU] Control num waves per EU for implicit work-group size (authored by pdhaliwal).
[AMDGPU] Control num waves per EU for implicit work-group size
Jul 1 2020, 7:59 PM
pdhaliwal closed D81991: [AMDGPU] Control num waves per EU for implicit work-group size.
Jul 1 2020, 7:58 PM · Restricted Project

Jun 30 2020

pdhaliwal added inline comments to D82847: [CMAKE] Fix 'clean' target not working.
Jun 30 2020, 7:00 PM · Restricted Project
pdhaliwal added a comment to D79400: [CMAKE] Fix build failure when source directory is read only.

Seems like this change causes ninja clean to fail with the error

ninja: error: remove(include/llvm/Support): Directory not empty

Full repro steps are

<cmake configuration>
ninja install
ninja clean

Simpler steps are

<cmake configuration>
ninja include/llvm/Support/all
ninja clean
Jun 30 2020, 1:02 AM · Restricted Project, Restricted Project
pdhaliwal created D82847: [CMAKE] Fix 'clean' target not working.
Jun 30 2020, 1:02 AM · Restricted Project

Jun 22 2020

pdhaliwal added a comment to D81991: [AMDGPU] Control num waves per EU for implicit work-group size.

@arsenm Please let me know if more information is required.

Jun 22 2020, 8:25 PM · Restricted Project

Jun 17 2020

pdhaliwal added a comment to D81991: [AMDGPU] Control num waves per EU for implicit work-group size.

My understanding is that clang already emits amdgpu-flat-work-group-size in range of [1, 256] as default value and HIP defaults to [1,1024]. And logic to calculate min-waves-per-eu is dependent on the maximum value of work-group size not minimum.

Jun 17 2020, 6:54 PM · Restricted Project

Jun 16 2020

pdhaliwal added reviewers for D81991: [AMDGPU] Control num waves per EU for implicit work-group size: rampitec, b-sumner, sameerds, msearles.
Jun 16 2020, 11:25 PM · Restricted Project
pdhaliwal created D81991: [AMDGPU] Control num waves per EU for implicit work-group size.
Jun 16 2020, 11:25 PM · Restricted Project

Jun 4 2020

pdhaliwal abandoned D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands.
Jun 4 2020, 6:14 PM · Restricted Project

Jun 2 2020

pdhaliwal added inline comments to D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands.
Jun 2 2020, 8:46 AM · Restricted Project
pdhaliwal updated the diff for D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands.

Added lit test case

Jun 2 2020, 7:08 AM · Restricted Project
pdhaliwal created D80996: [AMDGPU][OpenMP] Fix duplicate copies of arguments in commands.
Jun 2 2020, 5:31 AM · Restricted Project

May 29 2020

pdhaliwal updated the diff for D79400: [CMAKE] Fix build failure when source directory is read only.
May 29 2020, 3:13 AM · Restricted Project, Restricted Project

May 28 2020

pdhaliwal updated the diff for D79400: [CMAKE] Fix build failure when source directory is read only.
May 28 2020, 10:59 PM · Restricted Project, Restricted Project
pdhaliwal updated the diff for D79400: [CMAKE] Fix build failure when source directory is read only.
May 28 2020, 3:12 AM · Restricted Project, Restricted Project
pdhaliwal added inline comments to D79400: [CMAKE] Fix build failure when source directory is read only.
May 28 2020, 3:12 AM · Restricted Project, Restricted Project

May 27 2020

pdhaliwal updated the summary of D79400: [CMAKE] Fix build failure when source directory is read only.
May 27 2020, 10:53 PM · Restricted Project, Restricted Project

May 26 2020

pdhaliwal updated the diff for D79400: [CMAKE] Fix build failure when source directory is read only.
May 26 2020, 5:54 AM · Restricted Project, Restricted Project
pdhaliwal added a comment to D79400: [CMAKE] Fix build failure when source directory is read only.
  1. Another way is to gracefully handle the file write error, for which I don't think there is a portable way. (which @scott.linder also suggested)

I have found the portable way to do this. So cmake provides a command-line tool touch (doc) which can be used with [[ https://cmake.org/cmake/help/v3.0/command/execute_process.html | execute_process ]]. execute_process provides a way to suppress the failure using ERROR_QUIET option. Coming back to touch, it behaves similar to file(WRITE ..) command however, additionally the exit code can be used to check if file was created successfully. This retains the old behaviour while still solving the original problem. I will update the patch.

May 26 2020, 5:22 AM · Restricted Project, Restricted Project
pdhaliwal added a comment to D79400: [CMAKE] Fix build failure when source directory is read only.

Sorry for late reply.

May 26 2020, 3:12 AM · Restricted Project, Restricted Project

May 15 2020

pdhaliwal added a comment to D79400: [CMAKE] Fix build failure when source directory is read only.

I understand that .git/logs/HEAD acts as a dependency for vcs_revision_h target. However, problem here is that cmake fails when it tries to create .git/logs/HEAD in read-only filesystem.

May 15 2020, 3:02 AM · Restricted Project, Restricted Project

May 6 2020

pdhaliwal added a comment to D79400: [CMAKE] Fix build failure when source directory is read only.

Removing find_first_existing_vc_file makes a lot of sense, as since llvm has moved from svn to git, there is no need to have logic for svn dependency. Even the generation script is dependent on git executable only. I will keep my patch ready just in case other reviewers also feel the same.

May 6 2020, 9:01 PM · Restricted Project, Restricted Project

May 5 2020

pdhaliwal updated the diff for D79400: [CMAKE] Fix build failure when source directory is read only.

Added more context to diff.

May 5 2020, 11:57 PM · Restricted Project, Restricted Project
pdhaliwal added a comment to D79400: [CMAKE] Fix build failure when source directory is read only.

Can you provide more context in the diff? Looking at the current master locally it seems like this patch changes the behavior of the llvm_vcsrevision_h target when logs/HEAD isn't found, such that it only depends on the generation script. I.e. if you configure CMake without the HEAD file present, and then you do something which changes the working directory and creates HEAD the target will not be out of date and won't be rebuilt. Before this patch it would have noticed the change to HEAD and forced regenerating the version header.

If you look at the generation script https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/GenerateVersionFromVCS.cmake and https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/VersionFromVCS.cmake, these are not directly dependent on .git/logs/HEAD instead are dependent on .git/HEAD. The LLVM_REVISION is generated using following command

# https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/VersionFromVCS.cmake#L17
git rev-parse HEAD

which does not seem to use .git/logs/HEAD (instead uses .git/HEAD as revealed by strace)

May 5 2020, 11:57 PM · Restricted Project, Restricted Project
pdhaliwal added a reviewer for D79400: [CMAKE] Fix build failure when source directory is read only: msearles.
May 5 2020, 3:44 AM · Restricted Project, Restricted Project
pdhaliwal updated the summary of D79400: [CMAKE] Fix build failure when source directory is read only.
May 5 2020, 2:39 AM · Restricted Project, Restricted Project
pdhaliwal created D79400: [CMAKE] Fix build failure when source directory is read only.
May 5 2020, 2:06 AM · Restricted Project, Restricted Project