Page MenuHomePhabricator

pdhaliwal (Pushpinder Singh)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2020, 6:41 PM (108 w, 3 d)

Recent Activity

Dec 22 2021

pdhaliwal added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

I am seeing a lot of failures on nvptx machine (sm_70, cuda11.4) with this patch,

libomptarget :: nvptx64-nvidia-cuda :: offloading/bug49021.cpp
libomptarget :: nvptx64-nvidia-cuda :: offloading/bug49334.cpp
libomptarget :: nvptx64-nvidia-cuda :: offloading/bug49779.cpp
libomptarget :: nvptx64-nvidia-cuda :: offloading/bug51781.c
libomptarget :: nvptx64-nvidia-cuda :: offloading/bug51982.c
libomptarget :: nvptx64-nvidia-cuda :: unified_shared_memory/close_enter_exit.c
libomptarget :: nvptx64-nvidia-cuda :: unified_shared_memory/close_modifier.c
libomptarget :: nvptx64-nvidia-cuda :: unified_shared_memory/shared_update.c
libomptarget :: nvptx64-nvidia-cuda-newRTL :: offloading/bug49021.cpp
libomptarget :: nvptx64-nvidia-cuda-newRTL :: offloading/bug49334.cpp
libomptarget :: nvptx64-nvidia-cuda-newRTL :: offloading/bug51781.c
libomptarget :: nvptx64-nvidia-cuda-newRTL :: unified_shared_memory/close_enter_exit.c
libomptarget :: nvptx64-nvidia-cuda-newRTL :: unified_shared_memory/close_modifier.c
libomptarget :: nvptx64-nvidia-cuda-newRTL :: unified_shared_memory/shared_update.c

On amdgcn, these are the tests failing,

libomptarget :: amdgcn-amd-amdhsa :: offloading/bug49021.cpp
libomptarget :: amdgcn-amd-amdhsa :: offloading/bug51781.c
libomptarget :: amdgcn-amd-amdhsa :: offloading/bug51982.c
libomptarget :: amdgcn-amd-amdhsa-newRTL :: offloading/bug49021.cpp
libomptarget :: amdgcn-amd-amdhsa-newRTL :: offloading/bug51781.c
Dec 22 2021, 7:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 8 2021

pdhaliwal added a comment to D113253: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind.

Hi, this is again causing issues on amdgpu buildbot (https://lab.llvm.org/buildbot/#/builders/193). In the logs, I see that cmake was unable to find libelf dependency which is necessary for openmp plugins to be built and tested. In absence of libelf, the bot, currently, silently ignores and run non-amdgpu tests. I locally reverted this patch and found that tests are again working fine.

Dec 8 2021, 9:51 PM · Restricted Project, Restricted Project

Dec 6 2021

pdhaliwal accepted D114891: [openmp] Enable tests on new devicertl on amdgpu.

LGTM

Dec 6 2021, 7:23 AM · Restricted Project

Dec 1 2021

pdhaliwal abandoned D111218: [AMDGPU][OpenMP] Remove optnone from outlined functions.
Dec 1 2021, 6:39 AM · Restricted Project
pdhaliwal requested review of D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi.
Dec 1 2021, 5:25 AM · Restricted Project, Restricted Project

Nov 17 2021

pdhaliwal added a comment to D113253: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind.

If its helpful, following is the cmake command I used (cmake version: 3.20)

cmake ../llvm -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_RUNTIMES=openmp -DCLANG_DEFAULT_LINKER=lld -DLLVM_ENABLE_PROJECTS="lld;clang"
Nov 17 2021, 3:31 AM · Restricted Project, Restricted Project
pdhaliwal updated subscribers of D113253: [runtimes] Fix building initial libunwind+libcxxabi+libcxx with compiler implied -lunwind.

Hi, this patch is producing cmake errors in our amdgpu buildbot: https://lab.llvm.org/buildbot/#/builders/193. Initially I thought there was something wrong with our configuration, but git bisecting revealed that this commit is causing the issue. If I remove the following line, the build is fine.

project(Runtimes LANGUAGES NONE)
Nov 17 2021, 2:20 AM · Restricted Project, Restricted Project

Oct 6 2021

pdhaliwal retitled D111218: [AMDGPU][OpenMP] Remove optnone from outlined functions from [AMDGPU][OpenMP] Mark oulined functions always_inline to [AMDGPU][OpenMP] Remove optnone from outlined functions.
Oct 6 2021, 4:49 AM · Restricted Project
pdhaliwal updated the diff for D111218: [AMDGPU][OpenMP] Remove optnone from outlined functions.

Only removing optnone.

Oct 6 2021, 4:47 AM · Restricted Project
pdhaliwal planned changes to D111218: [AMDGPU][OpenMP] Remove optnone from outlined functions.

I don't have any concrete evidence but I have some doubt on presence of function pointers causing backend to behave improperly. Also, here removing optnone alone suffices to fix the issue.

Oct 6 2021, 4:05 AM · Restricted Project
pdhaliwal added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

I have created a patch (D111218) with fix for amdgcn. This is a temporary fix. I will still keep on looking into it until I find a real root cause.

Oct 6 2021, 3:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
pdhaliwal requested review of D111218: [AMDGPU][OpenMP] Remove optnone from outlined functions.
Oct 6 2021, 3:22 AM · Restricted Project

Sep 30 2021

Herald added a reviewer for D110902: [AMDGPU][Libomptarget] Refactor device and host pools setup into separate methods: jdoerfert.
Sep 30 2021, 8:47 PM · Restricted Project
pdhaliwal abandoned D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup.

Abandoning this in favor of D110902 due to dependency issues.

Sep 30 2021, 8:45 PM · Restricted Project
pdhaliwal requested review of D110902: [AMDGPU][Libomptarget] Refactor device and host pools setup into separate methods.
Sep 30 2021, 8:43 PM · Restricted Project
pdhaliwal added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

I modified the declare_mapper_target to print the contents of array after target region and found the following output:

2 3 4 5 6 7 8 9 10 11 Sum = 65
Sep 30 2021, 12:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 29 2021

pdhaliwal added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

Apologies for late reply. Most of the tests now do not try to call malloc, so no page fault errors. But all of them are producing wrong results. For e.g. declare_mapper_target.cpp produces Sum = 132608 with the patch applied. Similarly for other tests as well. So don't know what's happening yet.

Sep 29 2021, 4:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 27 2021

pdhaliwal committed rGb1695c2eb8df: [AMDGPU][OpenMP] Add memory pool size check to isValidMemoryPool (authored by pdhaliwal).
[AMDGPU][OpenMP] Add memory pool size check to isValidMemoryPool
Sep 27 2021, 5:29 AM
pdhaliwal closed D110513: [AMDGPU][OpenMP] Add memory pool size check to isValidMemoryPool.
Sep 27 2021, 5:29 AM · Restricted Project
pdhaliwal updated the diff for D110513: [AMDGPU][OpenMP] Add memory pool size check to isValidMemoryPool.
  • review comments
Sep 27 2021, 4:19 AM · Restricted Project
pdhaliwal updated the diff for D110513: [AMDGPU][OpenMP] Add memory pool size check to isValidMemoryPool.
Sep 27 2021, 2:53 AM · Restricted Project
pdhaliwal committed rG9d0eb440ff40: [libomptarget][nfc][amdgpu] Reorder function to clarify review diff (authored by pdhaliwal).
[libomptarget][nfc][amdgpu] Reorder function to clarify review diff
Sep 27 2021, 2:31 AM

Sep 26 2021

pdhaliwal added inline comments to D110513: [AMDGPU][OpenMP] Add memory pool size check to isValidMemoryPool.
Sep 26 2021, 7:51 PM · Restricted Project
pdhaliwal requested review of D110513: [AMDGPU][OpenMP] Add memory pool size check to isValidMemoryPool.
Sep 26 2021, 7:50 PM · Restricted Project

Sep 22 2021

pdhaliwal abandoned D110306: [AMDGPU][Libomptarget] Simplify host memory pool lookup.
Sep 22 2021, 10:48 PM · Restricted Project
pdhaliwal requested review of D110306: [AMDGPU][Libomptarget] Simplify host memory pool lookup.
Sep 22 2021, 10:44 PM · Restricted Project
pdhaliwal updated the diff for D109866: [AMDGPU][Libomptarget] Simplify host memory pool lookup.

Rebase

Sep 22 2021, 9:50 PM · Restricted Project
pdhaliwal added inline comments to D105191: [Clang][OpenMP] Add partial support for Static Device Libraries.
Sep 22 2021, 6:18 AM · Restricted Project
pdhaliwal added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

I got this after changing __kmpc_impl_malloc to return 0xdeadbeef. So, this confirms that missing malloc implementation is the root cause.

Memory access fault by GPU node-4 (Agent handle: 0x1bc5000) on address 0xdeadb000. Reason: Page not present or supervisor privilege.

Sep 22 2021, 3:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
pdhaliwal added a comment to D102107: [OpenMP] Codegen aggregate for outlined function captures.

It looks like from IR diff that this patch is adding use of kmpc_alloc_shared method. These methods likely won't work on AMDGPU as device malloc is not available. Not sure what could be done apart from marking those tests as XFAIL on amdgcn. :(

Sep 22 2021, 1:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 20 2021

pdhaliwal accepted D109511: [libomptarget][amdgpu] Destruct HSA queues.

Looks good.

Sep 20 2021, 5:42 AM · Restricted Project
pdhaliwal updated the diff for D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup.

update logic for fine-grained/kernarg pools

Sep 20 2021, 5:18 AM · Restricted Project

Sep 19 2021

pdhaliwal added a comment to D109866: [AMDGPU][Libomptarget] Simplify host memory pool lookup.

This is not dependent on D109875, instead it is the other case. Apologies for not mentioning here. Diff shown here is messed up.

Sep 19 2021, 8:55 PM · Restricted Project
pdhaliwal added inline comments to D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup.
Sep 19 2021, 8:50 PM · Restricted Project

Sep 17 2021

pdhaliwal added inline comments to D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup.
Sep 17 2021, 1:52 AM · Restricted Project
pdhaliwal updated the diff for D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup.

Check if both values are set properly.

Sep 17 2021, 1:51 AM · Restricted Project

Sep 16 2021

pdhaliwal updated the diff for D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup.

run clang-format

Sep 16 2021, 4:11 AM · Restricted Project
pdhaliwal retitled D109866: [AMDGPU][Libomptarget] Simplify host memory pool lookup from [AMDGPU][Libomptarget] Simplify setup of host/device memory pools to [AMDGPU][Libomptarget] Simplify host memory pool lookup.
Sep 16 2021, 4:07 AM · Restricted Project
pdhaliwal updated the diff for D109866: [AMDGPU][Libomptarget] Simplify host memory pool lookup.

Split this patch into two,

  1. Current patch now only includes changes for simplifying the host pool lookup
  2. D109875 includes plain refactoring.
Sep 16 2021, 4:05 AM · Restricted Project
pdhaliwal requested review of D109875: [AMDGPU][Libomptarget] Refactor device/host memory pools setup.
Sep 16 2021, 4:03 AM · Restricted Project

Sep 15 2021

pdhaliwal requested review of D109866: [AMDGPU][Libomptarget] Simplify host memory pool lookup.
Sep 15 2021, 7:39 PM · Restricted Project

Sep 14 2021

pdhaliwal added a comment to D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h.

Even with declare variant separated using ifdef's, the error is still there. So I don't think we have workaround for this.

Sep 14 2021, 1:20 AM · Restricted Project

Sep 13 2021

pdhaliwal added a comment to D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h.

Hey, Jon, sorry for late reply. I cannot reproduce this issue on nvptx so it seems to occur only on amdgcn. Will it be better if instead the name mangling issue is fixed? Or for the meantime, I could add #ifdef around as a temporary fix. Suggestions?

Sep 13 2021, 5:24 AM · Restricted Project

Sep 9 2021

pdhaliwal accepted D109512: [libomptarget][amdgpu] Precisely manage hsa lifetime.

Looks good! Thanks.

Sep 9 2021, 9:25 AM · Restricted Project
pdhaliwal added inline comments to D109512: [libomptarget][amdgpu] Precisely manage hsa lifetime.
Sep 9 2021, 8:44 AM · Restricted Project

Sep 7 2021

pdhaliwal updated the diff for D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h.

Add amdgcn to the same arch list as nvptx

Sep 7 2021, 1:47 AM · Restricted Project
pdhaliwal requested review of D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h.
Sep 7 2021, 12:34 AM · Restricted Project

Sep 1 2021

pdhaliwal accepted D108784: [libomptarget][amdgpu] Drop env variables.

LGTM

Sep 1 2021, 11:34 PM · Restricted Project

Aug 26 2021

pdhaliwal accepted D108774: [OpenMP][FIX] Allow declare variant to work with reference types.

Confirmed locally that this fixes the linking issue. It has fixed the linking issue on amdgcn as well. Thanks for working on this.

Aug 26 2021, 11:16 PM · Restricted Project

Aug 24 2021

pdhaliwal committed rG9b8b7c1180eb: [AMDGPU][Libomptarget] Delete g_atl_machine global (authored by pdhaliwal).
[AMDGPU][Libomptarget] Delete g_atl_machine global
Aug 24 2021, 1:00 AM
pdhaliwal closed D104696: [AMDGPU][Libomptarget] Delete g_atl_machine global.
Aug 24 2021, 1:00 AM · Restricted Project
pdhaliwal added a comment to D104696: [AMDGPU][Libomptarget] Delete g_atl_machine global.

Oh sorry, forgot about this. Landing it now.

Aug 24 2021, 12:56 AM · Restricted Project

Aug 23 2021

pdhaliwal requested review of D108552: [OpenMP][AMDGCN] Enable complex functions.
Aug 23 2021, 6:13 AM · Restricted Project

Aug 12 2021

pdhaliwal added inline comments to D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries.
Aug 12 2021, 4:29 AM · Restricted Project
pdhaliwal updated the diff for D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries.

Remove redundant test

Aug 12 2021, 4:27 AM · Restricted Project
pdhaliwal requested review of D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries.
Aug 12 2021, 1:47 AM · Restricted Project

Aug 10 2021

pdhaliwal updated the diff for D104696: [AMDGPU][Libomptarget] Delete g_atl_machine global.

Rebase

Aug 10 2021, 11:38 PM · Restricted Project

Aug 4 2021

pdhaliwal committed rGf3eb5f900d2a: [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef (authored by pdhaliwal).
[AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef
Aug 4 2021, 8:25 AM
pdhaliwal closed D107468: [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef.
Aug 4 2021, 8:25 AM · Restricted Project
pdhaliwal requested review of D107468: [AMDGPU][OpenMP] Wrap amdgcn declare variant inside ifdef.
Aug 4 2021, 8:13 AM · Restricted Project
pdhaliwal added inline comments to D104904: [OpenMP][AMDGCN] Initial math headers support.
Aug 4 2021, 8:11 AM · Restricted Project

Aug 2 2021

pdhaliwal committed rG713a5d12cde5: [OpenMP][AMDGCN] Initial math headers support (authored by pdhaliwal).
[OpenMP][AMDGCN] Initial math headers support
Aug 2 2021, 7:39 AM
pdhaliwal closed D104904: [OpenMP][AMDGCN] Initial math headers support.
Aug 2 2021, 7:39 AM · Restricted Project
pdhaliwal added a comment to D104904: [OpenMP][AMDGCN] Initial math headers support.

@ye-luo and @JonChesterfield can you please test the latest version of this patch? It should work now.

Aug 2 2021, 12:21 AM · Restricted Project
pdhaliwal updated the diff for D104904: [OpenMP][AMDGCN] Initial math headers support.

Fixed compilation error for nvptx headers. Tested on both cuda and non-cuda systems.

Aug 2 2021, 12:20 AM · Restricted Project

Jul 30 2021

pdhaliwal committed rG12da97ea10a9: [OpenMP][AMDGCN] Initial math headers support (authored by pdhaliwal).
[OpenMP][AMDGCN] Initial math headers support
Jul 30 2021, 7:53 AM
pdhaliwal closed D104904: [OpenMP][AMDGCN] Initial math headers support.
Jul 30 2021, 7:53 AM · Restricted Project
pdhaliwal updated the diff for D104904: [OpenMP][AMDGCN] Initial math headers support.

Addressed review comments.

Jul 30 2021, 7:51 AM · Restricted Project
pdhaliwal committed rG9830f902e4d0: [AMDGPU][OpenMP] Support linking of math libraries (authored by pdhaliwal).
[AMDGPU][OpenMP] Support linking of math libraries
Jul 30 2021, 6:55 AM
pdhaliwal closed D105981: [AMDGPU][OpenMP] Support linking of math libraries.
Jul 30 2021, 6:54 AM · Restricted Project
pdhaliwal updated the diff for D104904: [OpenMP][AMDGCN] Initial math headers support.

It required some work to fix the failing lit test case. And many thanks to
@estewart for helping in that.

Jul 30 2021, 2:10 AM · Restricted Project

Jul 29 2021

pdhaliwal updated the diff for D105981: [AMDGPU][OpenMP] Support linking of math libraries.

Missed comment.

Jul 29 2021, 4:37 AM · Restricted Project
pdhaliwal updated the diff for D105981: [AMDGPU][OpenMP] Support linking of math libraries.

Rename method to getCommonDeviceLibNames

Jul 29 2021, 4:36 AM · Restricted Project

Jul 28 2021

pdhaliwal added a comment to D105981: [AMDGPU][OpenMP] Support linking of math libraries.

Due to the current state of math headers, I was unable to test this patch without ockl. But last time when headers were working, I was actually required to link ockl for a symbol (I forgot the name). I will update once I am able to get the math headers work again.

Jul 28 2021, 6:55 AM · Restricted Project

Jul 27 2021

pdhaliwal added inline comments to D105981: [AMDGPU][OpenMP] Support linking of math libraries.
Jul 27 2021, 3:51 AM · Restricted Project
pdhaliwal updated the diff for D105981: [AMDGPU][OpenMP] Support linking of math libraries.

Extract the options from HIP/OpenMP to a common method in base class.

Jul 27 2021, 3:48 AM · Restricted Project

Jul 15 2021

pdhaliwal added a comment to D104696: [AMDGPU][Libomptarget] Delete g_atl_machine global.

I need to rebase this.

Jul 15 2021, 7:16 PM · Restricted Project

Jul 14 2021

pdhaliwal updated the diff for D105981: [AMDGPU][OpenMP] Support linking of math libraries.

Move linking logic to a common method.

Jul 14 2021, 8:18 AM · Restricted Project
pdhaliwal added inline comments to D105981: [AMDGPU][OpenMP] Support linking of math libraries.
Jul 14 2021, 7:55 AM · Restricted Project
pdhaliwal requested review of D105981: [AMDGPU][OpenMP] Support linking of math libraries.
Jul 14 2021, 7:36 AM · Restricted Project
pdhaliwal added a comment to D105221: [openmp][nfc] Simplify macros guarding math complex headers.

Looks ok to me. Regression tests and runtime tests went fine. Tested a simple cuda and openmp kernel with sin function on sm_61, didn't see any issue.

Jul 14 2021, 6:04 AM · Restricted Project

Jul 1 2021

pdhaliwal added a comment to D105221: [openmp][nfc] Simplify macros guarding math complex headers.

Should the name of file be changed as well?

Jul 1 2021, 4:38 AM · Restricted Project
pdhaliwal accepted D105237: [libomptarget][nfc] Move grid size computation.

Looks good! Thanks.

Jul 1 2021, 4:37 AM · Restricted Project

Jun 30 2021

pdhaliwal added inline comments to D104904: [OpenMP][AMDGCN] Initial math headers support.
Jun 30 2021, 3:59 AM · Restricted Project

Jun 28 2021

pdhaliwal added inline comments to D104904: [OpenMP][AMDGCN] Initial math headers support.
Jun 28 2021, 8:37 AM · Restricted Project
pdhaliwal updated the diff for D104904: [OpenMP][AMDGCN] Initial math headers support.
  • Move constant to openmp_wrappers/cmath
  • Using push/pop_macro to avoid redefinition
Jun 28 2021, 8:37 AM · Restricted Project
pdhaliwal accepted D104923: [libomptarget][amdgpu][nfc] Fix build warnings, drop some headers.

Looks good! Thanks

Jun 28 2021, 5:37 AM · Restricted Project
pdhaliwal committed rG20df2c7052c0: [AMDGPU][Libomptarget] Collect allocatable memory pools using HSA (authored by pdhaliwal).
[AMDGPU][Libomptarget] Collect allocatable memory pools using HSA
Jun 28 2021, 4:28 AM
pdhaliwal closed D104695: [AMDGPU][Libomptarget] Collect allocatable memory pools using HSA.
Jun 28 2021, 4:28 AM · Restricted Project
pdhaliwal updated the diff for D104904: [OpenMP][AMDGCN] Initial math headers support.

Typo

Jun 28 2021, 1:35 AM · Restricted Project
pdhaliwal added inline comments to D104904: [OpenMP][AMDGCN] Initial math headers support.
Jun 28 2021, 1:31 AM · Restricted Project
pdhaliwal updated the diff for D104904: [OpenMP][AMDGCN] Initial math headers support.

Addressed review comments.

Jun 28 2021, 1:31 AM · Restricted Project

Jun 25 2021

pdhaliwal updated the diff for D104904: [OpenMP][AMDGCN] Initial math headers support.

Fix format errors

Jun 25 2021, 5:11 AM · Restricted Project
pdhaliwal added reviewers for D104904: [OpenMP][AMDGCN] Initial math headers support: yaxunl, scchan.
Jun 25 2021, 3:00 AM · Restricted Project
pdhaliwal requested review of D104904: [OpenMP][AMDGCN] Initial math headers support.
Jun 25 2021, 2:58 AM · Restricted Project

Jun 23 2021

pdhaliwal updated the diff for D104695: [AMDGPU][Libomptarget] Collect allocatable memory pools using HSA.

Addressed review comments.

Jun 23 2021, 1:03 AM · Restricted Project

Jun 22 2021

pdhaliwal updated the diff for D104695: [AMDGPU][Libomptarget] Collect allocatable memory pools using HSA.

Fix clang-tidy errors and use scalar for host memory pool.

Jun 22 2021, 5:51 AM · Restricted Project
pdhaliwal committed rG9d110f915918: [AMDGPU][Libomptarget] Move allow_access_to_all_gpu_agents to rtl.cpp (authored by pdhaliwal).
[AMDGPU][Libomptarget] Move allow_access_to_all_gpu_agents to rtl.cpp
Jun 22 2021, 4:45 AM
pdhaliwal closed D104691: [AMDGPU][Libomptarget] Move allow_access_to_all_gpu_agents to rtl.cpp.
Jun 22 2021, 4:45 AM · Restricted Project
pdhaliwal added inline comments to D104695: [AMDGPU][Libomptarget] Collect allocatable memory pools using HSA.
Jun 22 2021, 4:28 AM · Restricted Project