Page MenuHomePhabricator

pdhaliwal (Pushpinder Singh)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2020, 6:41 PM (51 w, 4 d)

Recent Activity

Today

pdhaliwal updated the diff for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

Review comments addressed.

Tue, Apr 20, 6:04 AM · Restricted Project
pdhaliwal requested review of D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.
Tue, Apr 20, 4:00 AM · Restricted Project
pdhaliwal updated the diff for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

Reopening this. This version is supposed to fix the buildbot failures on PPC machines.
Since I don't have PPC machine I am not sure if this will work. But the logic
followed here is motivated from Clang :: Driver/program-path-priority.c, so hopefully
it will pass the CI.

Tue, Apr 20, 3:59 AM · Restricted Project
pdhaliwal reopened D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.
Tue, Apr 20, 3:59 AM · Restricted Project

Fri, Apr 16

pdhaliwal added a comment to D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

I've reverted this from main for now as there seems to be issue with executing test script on some CI machines.

Fri, Apr 16, 2:18 AM · Restricted Project
pdhaliwal added a reverting change for rG7029cffc4e78: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed: rGefc013ec4d95: Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed".
Fri, Apr 16, 2:17 AM
pdhaliwal committed rGefc013ec4d95: Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed" (authored by pdhaliwal).
Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed"
Fri, Apr 16, 2:17 AM
pdhaliwal added a reverting change for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed: rGefc013ec4d95: Revert "[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed".
Fri, Apr 16, 2:17 AM · Restricted Project

Thu, Apr 15

pdhaliwal committed rG7029cffc4e78: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed (authored by pdhaliwal).
[AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed
Thu, Apr 15, 10:27 PM
pdhaliwal closed D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.
Thu, Apr 15, 10:26 PM · Restricted Project

Wed, Apr 14

pdhaliwal updated the diff for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

Rebase and review comments

Wed, Apr 14, 11:39 PM · Restricted Project

Fri, Apr 9

pdhaliwal updated the diff for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

Fix permissions

Fri, Apr 9, 2:00 AM · Restricted Project
pdhaliwal updated the diff for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

Added tests for the failing cases

Fri, Apr 9, 1:58 AM · Restricted Project

Thu, Apr 8

pdhaliwal updated the diff for D99656: [AMDGPU][OpenMP] Enable Libomptarget runtime tests.
  • Addressed review comments.
Thu, Apr 8, 4:44 AM · Restricted Project
pdhaliwal updated the diff for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.
  • Addressed review comments
  • Added LIT test case
Thu, Apr 8, 2:13 AM · Restricted Project

Wed, Apr 7

pdhaliwal added a reviewer for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed: yaxunl.
Wed, Apr 7, 2:26 AM · Restricted Project
pdhaliwal added a comment to D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.
Wed, Apr 7, 2:25 AM · Restricted Project
pdhaliwal updated the diff for D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

Addressed review comments.

Wed, Apr 7, 2:24 AM · Restricted Project

Tue, Apr 6

pdhaliwal planned changes to D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.

Working on tests.

Tue, Apr 6, 5:22 AM · Restricted Project
pdhaliwal requested review of D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed.
Tue, Apr 6, 5:21 AM · Restricted Project

Wed, Mar 31

pdhaliwal added inline comments to D99656: [AMDGPU][OpenMP] Enable Libomptarget runtime tests.
Wed, Mar 31, 7:34 AM · Restricted Project
pdhaliwal requested review of D99656: [AMDGPU][OpenMP] Enable Libomptarget runtime tests.
Wed, Mar 31, 5:19 AM · Restricted Project

Mon, Mar 29

pdhaliwal added a comment to D99402: [AMDGPU][OpenMP] Add <install-prefix>/include to the search path.

The general problem seems bit more involved. I am not that familiar with how other architectures/systems handle the library/include path. Simplest solution that I can propose right now is to generalise my revision to other architectures for header lookup and similarly for library lookup in case of openmp. If there is better solution available please let me know I will be happy to implement it.

Mon, Mar 29, 4:14 AM · Restricted Project

Fri, Mar 26

pdhaliwal added a comment to D99402: [AMDGPU][OpenMP] Add <install-prefix>/include to the search path.

I was not aware that it was a general problem. I will check if I could get a general solution.

Fri, Mar 26, 4:31 AM · Restricted Project
pdhaliwal requested review of D99402: [AMDGPU][OpenMP] Add <install-prefix>/include to the search path.
Fri, Mar 26, 1:49 AM · Restricted Project

Mon, Mar 22

pdhaliwal committed rGd0e5422eb8bf: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO (authored by pdhaliwal).
[GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO
Mon, Mar 22, 10:46 PM
pdhaliwal closed D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Mon, Mar 22, 10:46 PM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Fix comments.

Mon, Mar 22, 1:45 AM · Restricted Project
pdhaliwal added inline comments to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Mon, Mar 22, 1:27 AM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
  • Revert the unsigned case to use Masks.
  • Simplified the logic for widenScalar
Mon, Mar 22, 1:26 AM · Restricted Project

Mar 19 2021

pdhaliwal added inline comments to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Mar 19 2021, 6:01 AM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Removed assert. Now WideTy overflow check is only done when WideTy is not sufficient enough.
Added test case for s24 to verify the logic.

Mar 19 2021, 6:01 AM · Restricted Project

Mar 18 2021

pdhaliwal added inline comments to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Mar 18 2021, 12:32 AM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Use SHRL for unsigned case.

Mar 18 2021, 12:31 AM · Restricted Project

Mar 17 2021

pdhaliwal added a comment to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Ping!

Mar 17 2021, 6:46 AM · Restricted Project

Mar 15 2021

pdhaliwal committed rGfc12a64ecc71: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn (authored by pdhaliwal).
[OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn
Mar 15 2021, 9:58 PM
pdhaliwal closed D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.
Mar 15 2021, 9:58 PM · Restricted Project

Mar 9 2021

pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Rebase & Review comments

Mar 9 2021, 12:30 AM · Restricted Project

Feb 25 2021

pdhaliwal updated the diff for D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.

Add extra llc step to produce assembly in the linker.

Feb 25 2021, 7:58 AM · Restricted Project
pdhaliwal added a comment to D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.

So, neither emit-llvm-bc or emit-llvm work well with save-temps. Therefore, I feel the current approach is still valid. This does not impact nvptx or any other target in any way. And I don't see how.

Feb 25 2021, 7:04 AM · Restricted Project

Feb 24 2021

pdhaliwal committed rG99951aa68da3: OpenMP: Fix object clobbering issue when using save-temps (authored by pdhaliwal).
OpenMP: Fix object clobbering issue when using save-temps
Feb 24 2021, 9:51 PM
pdhaliwal closed D97273: OpenMP: Fix object clobbering issue when using save-temps.
Feb 24 2021, 9:51 PM · Restricted Project

Feb 23 2021

pdhaliwal added a reviewer for D97273: OpenMP: Fix object clobbering issue when using save-temps: sdmitriev.
Feb 23 2021, 8:07 AM · Restricted Project
pdhaliwal added a comment to D97273: OpenMP: Fix object clobbering issue when using save-temps.

Here's a bit of background,
OffloadingPrefix was not getting properly set in the dependent actions of OffloadWrapperJobAction (which are backend [11] and assemble [12]). Since backend [11] and assemble [12] host-wrapper actions have same logic to the other host actions (3 & 4), those will overwrite the previous generated files from host-only actions.

Feb 23 2021, 8:05 AM · Restricted Project
pdhaliwal updated the summary of D97273: OpenMP: Fix object clobbering issue when using save-temps.
Feb 23 2021, 6:11 AM · Restricted Project
pdhaliwal updated the summary of D97273: OpenMP: Fix object clobbering issue when using save-temps.
Feb 23 2021, 5:48 AM · Restricted Project
pdhaliwal requested review of D97273: OpenMP: Fix object clobbering issue when using save-temps.
Feb 23 2021, 5:06 AM · Restricted Project

Feb 18 2021

pdhaliwal accepted D96998: [OPENMP][AMDGCN] Improvements to print_kernel_trace (bit mask).

Looks good to me. Thanks!

Feb 18 2021, 5:38 PM · Restricted Project

Feb 17 2021

pdhaliwal added inline comments to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Feb 17 2021, 2:37 AM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Fixed the assert.

Feb 17 2021, 2:36 AM · Restricted Project

Feb 16 2021

pdhaliwal added a comment to D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.

It is because of how addClangTargetOptions is invoked. In case of save-temps, it is being invoked for all the actions resulting in target cc1 call. That's why all these invocations have -emit-llvm-bc. I guess we need Action as an argument to addClangTargetOptions.

Feb 16 2021, 8:28 AM · Restricted Project
pdhaliwal added a comment to D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.

emit-llvm-bc does not correctly solve the problem. It works because [input, compile, assemble, backend] actions collapse to a single action by driver. This single command handles emit-llvm-bc properly. But when save-temps is specified, this collapsing does not happen which messes up command line flags of the jobs and hence the output, for e.g., preprocessor command also has -emit-llvm-bc.

Feb 16 2021, 7:59 AM · Restricted Project
pdhaliwal added a comment to D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.

This does fixes the save-temps but only when -o is not specified. If -o is specified (along with -save-temps), the name of host object file and host-wrapper object file (second last phase) is same, which fails the linker. This does not seem to be related to this patch.

Feb 16 2021, 6:15 AM · Restricted Project
pdhaliwal added inline comments to D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.
Feb 16 2021, 4:26 AM · Restricted Project
pdhaliwal requested review of D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn.
Feb 16 2021, 4:24 AM · Restricted Project

Feb 15 2021

pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Addressed review comments.

Feb 15 2021, 11:11 PM · Restricted Project
pdhaliwal added a comment to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Can you use -check-prefixes=GCN,GFX8 and GCN,GFX9 so that update_mir_test_checks will common up the identical ones?

It does not work. Script warns as WARNING: Ignoring common prefixes: {'GCN'}: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-umulo.mir

Feb 15 2021, 1:15 AM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Addressed review comments.

Feb 15 2021, 1:06 AM · Restricted Project

Feb 11 2021

pdhaliwal committed rG79401b43ce4e: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode (authored by Pushpinder Singh <pushpinderdhaliwal00@gmail.com>).
[OpenMP][AMDGPU] Add support for linking libomptarget bitcode
Feb 11 2021, 9:43 PM
pdhaliwal closed D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode.
Feb 11 2021, 9:42 PM · Restricted Project

Feb 10 2021

pdhaliwal updated the diff for D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode.

I have removed libomptarget-device-bc-path and have added amdgcn one. For diagnostic,
instead of having one per architecture, I have used the same and added second
parameter to err_drv_omp_offload_target_missingbcruntime for having arch specifc message.

Feb 10 2021, 3:22 AM · Restricted Project

Feb 9 2021

pdhaliwal accepted D96330: [libomptarget][amdgcn] Tolerate deadstripped device_state variable.

LGTM. Thanks!

Feb 9 2021, 4:50 AM · Restricted Project
pdhaliwal accepted D96329: [libomptarget][amdgcn] Tolerate deadstripped env variable.

LGTM, thanks for fixing it.

Feb 9 2021, 3:56 AM · Restricted Project

Feb 8 2021

pdhaliwal updated the diff for D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode.
  • Added check for nogpulib
  • Fixed diagnostic message
Feb 8 2021, 11:36 PM · Restricted Project
pdhaliwal updated the diff for D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode.

Addressed review comments.

Feb 8 2021, 5:47 AM · Restricted Project
pdhaliwal updated the diff for D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode.

Missed some changes,

  • Fix openmp-offload.c test failure
  • Fix amdgpu-openmp-toolchain.c test failure
Feb 8 2021, 1:51 AM · Restricted Project
pdhaliwal added a comment to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Ping!

Feb 8 2021, 1:23 AM · Restricted Project
pdhaliwal requested review of D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode.
Feb 8 2021, 1:15 AM · Restricted Project

Feb 2 2021

pdhaliwal committed rGfcf03e728007: [OpenMP] Add OpenMP offloading toolchain for AMDGPU (authored by Pushpinder Singh <pushpinderdhaliwal00@gmail.com>).
[OpenMP] Add OpenMP offloading toolchain for AMDGPU
Feb 2 2021, 9:43 PM
pdhaliwal closed D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.
Feb 2 2021, 9:43 PM · Restricted Project
pdhaliwal added inline comments to D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.
Feb 2 2021, 3:59 AM · Restricted Project
pdhaliwal updated the diff for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.
  • Use 0 for default -O option
  • Rename addOptLevelArgs to addLLCOptArg
Feb 2 2021, 3:58 AM · Restricted Project
pdhaliwal added a comment to D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.

After addressing the review comments, I have internally verified changes on few simple test programs. They seem to be working fine.

Feb 2 2021, 2:47 AM · Restricted Project
pdhaliwal updated the diff for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.

Addressed review comments.

  • Combined the toolchain creation logic for nvptx and amdgcn
  • Replaced -Xopenmp-target with -emit-llvm-bc inside AMDGPUOpenMP.cpp
  • Removed opt from pipeline
Feb 2 2021, 2:39 AM · Restricted Project

Feb 1 2021

pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
  • Scalarize the vectors first
  • Using widened operation for smaller types
Feb 1 2021, 3:11 AM · Restricted Project
pdhaliwal added a comment to D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.

Ping!

Feb 1 2021, 2:08 AM · Restricted Project

Jan 28 2021

pdhaliwal added a reviewer for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO: foad.
Jan 28 2021, 2:27 AM · Restricted Project
pdhaliwal added a comment to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Hi, apologies for late reply as I got sidetracked to some other work.

Jan 28 2021, 2:27 AM · Restricted Project

Jan 27 2021

pdhaliwal added a reviewer for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU: saiislam.
Jan 27 2021, 6:42 AM · Restricted Project

Jan 20 2021

pdhaliwal added a reviewer for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU: yaxunl.
Jan 20 2021, 11:54 PM · Restricted Project
pdhaliwal updated the diff for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.
  • Moved common methods of HIP and OpenMP to base AMDGPUToolChain
  • Removed unnecessary asserts
Jan 20 2021, 11:51 PM · Restricted Project
pdhaliwal updated the diff for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.

Fixed failing debian tests

Jan 20 2021, 4:09 AM · Restricted Project
pdhaliwal retitled D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU from [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU to [OpenMP] Add OpenMP offloading toolchain for AMDGPU.
Jan 20 2021, 2:16 AM · Restricted Project
pdhaliwal updated the diff for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.

Won't this just prevent us from building clang due to the missing cmake changes?

It compiles and builds fine, however, I wasn't actually aware such sanity checking being present. It turns out
the unknown files inside llvm/ will lead cmake to report error but such reporting will not happen inside clang. Maybe such checks
were not enabled inside clang. Anyways thanks for pointing out. I will keep that in mind in future.

Jan 20 2021, 1:49 AM · Restricted Project

Jan 19 2021

pdhaliwal updated the diff for D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.

Fix clang-tidy error

Jan 19 2021, 6:56 AM · Restricted Project
pdhaliwal requested review of D94961: [OpenMP] Add OpenMP offloading toolchain for AMDGPU.
Jan 19 2021, 3:45 AM · Restricted Project

Jan 14 2021

pdhaliwal added inline comments to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Jan 14 2021, 10:26 PM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Moved ops close to ADDO

Jan 14 2021, 10:22 PM · Restricted Project

Jan 10 2021

pdhaliwal added inline comments to D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Jan 10 2021, 11:45 PM · Restricted Project
pdhaliwal updated the diff for D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.

Removed global-isel-abort=0

Jan 10 2021, 11:44 PM · Restricted Project

Jan 5 2021

pdhaliwal committed rG4909cb1a0fe9: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function (authored by pdhaliwal).
[OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function
Jan 5 2021, 11:04 PM
pdhaliwal closed D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function.
Jan 5 2021, 11:03 PM · Restricted Project

Jan 4 2021

pdhaliwal requested review of D94060: [OpenMP][AMDGPU] Use AMDGPU_KERNEL calling convention for entry function.
Jan 4 2021, 8:54 PM · Restricted Project

Jan 1 2021

pdhaliwal requested review of D93963: [GlobalISel][AMDGPU] Lower G_UMULO/G_SMULO.
Jan 1 2021, 2:58 AM · Restricted Project

Dec 20 2020

pdhaliwal committed rGe2303a448e2f: [FastRA] Fix handling of bundled MIs (authored by pdhaliwal).
[FastRA] Fix handling of bundled MIs
Dec 20 2020, 11:11 PM
pdhaliwal closed D90369: [FastRA] Fix handling of bundled MIs.
Dec 20 2020, 11:11 PM · Restricted Project
pdhaliwal updated the diff for D90369: [FastRA] Fix handling of bundled MIs.

Update AMDGPU barrier intrinsic

Dec 20 2020, 11:08 PM · Restricted Project

Dec 7 2020

pdhaliwal added a comment to D90369: [FastRA] Fix handling of bundled MIs.

Ping!

Dec 7 2020, 2:36 AM · Restricted Project

Dec 3 2020

pdhaliwal accepted D92559: [libomptarget][amdgpu] Address compiler warnings, drive by fixes.

Looks good, thanks.

Dec 3 2020, 2:54 AM · Restricted Project

Dec 2 2020

pdhaliwal committed rGafc09c6fe44e: [libomptarget][AMDGPU] Remove MaxParallelLevel (authored by pdhaliwal).
[libomptarget][AMDGPU] Remove MaxParallelLevel
Dec 2 2020, 9:27 PM