- User Since
- Apr 23 2020, 6:41 PM (21 w, 3 d)
Thu, Sep 17
Updated tests and clamping number of elements to 2
Mon, Sep 7
Thu, Sep 3
Only places where it was accessed are here and here. Jon's observation is correct. The maximum number of threads on both amdgcn and nvptx is 1024. However, on amdgcn, wave size is 64 and so maximum number of waves can be 16 and on nvptx, the warp size is 32 and maximum number of warps is 32.
Wed, Sep 2
@arsenm , let me know if it is good to land.
Sun, Aug 30
Updated review comments.
Aug 11 2020
Added support for vector types.
Aug 10 2020
removed unneeded changes
Jul 29 2020
Jul 21 2020
Added runRUN lines with OpenMP 5.0 version option
Jul 20 2020
Jul 13 2020
@phosek Let me know if this is good to land.
Jul 2 2020
Jul 1 2020
Jun 30 2020
Jun 22 2020
@arsenm Please let me know if more information is required.
Jun 17 2020
My understanding is that clang already emits amdgpu-flat-work-group-size in range of [1, 256] as default value and HIP defaults to [1,1024]. And logic to calculate min-waves-per-eu is dependent on the maximum value of work-group size not minimum.
Jun 16 2020
Jun 4 2020
Jun 2 2020
Added lit test case
May 29 2020
May 28 2020
May 27 2020
May 26 2020
- Another way is to gracefully handle the file write error, for which I don't think there is a portable way. (which @scott.linder also suggested)
I have found the portable way to do this. So cmake provides a command-line tool touch (doc) which can be used with [[ https://cmake.org/cmake/help/v3.0/command/execute_process.html | execute_process ]]. execute_process provides a way to suppress the failure using ERROR_QUIET option. Coming back to touch, it behaves similar to file(WRITE ..) command however, additionally the exit code can be used to check if file was created successfully. This retains the old behaviour while still solving the original problem. I will update the patch.
Sorry for late reply.
May 15 2020
I understand that .git/logs/HEAD acts as a dependency for vcs_revision_h target. However, problem here is that cmake fails when it tries to create .git/logs/HEAD in read-only filesystem.
May 6 2020
Removing find_first_existing_vc_file makes a lot of sense, as since llvm has moved from svn to git, there is no need to have logic for svn dependency. Even the generation script is dependent on git executable only. I will keep my patch ready just in case other reviewers also feel the same.
May 5 2020
Added more context to diff.
If you look at the generation script https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/GenerateVersionFromVCS.cmake and https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/VersionFromVCS.cmake, these are not directly dependent on .git/logs/HEAD instead are dependent on .git/HEAD. The LLVM_REVISION is generated using following command
# https://github.com/llvm/llvm-project/blob/master/llvm/cmake/modules/VersionFromVCS.cmake#L17 git rev-parse HEAD
which does not seem to use .git/logs/HEAD (instead uses .git/HEAD as revealed by strace)