This is an archive of the discontinued LLVM Phabricator instance.

Differential D109720

[Bazel][mlir] Simplify test/BUILD.bazel with globs
ClosedPublic

Authored by GMNGeoffrey on Sep 13 2021, 1:25 PM.

Details

Reviewers
bkramer
mehdi_amini
Commits
rG095bbc3a5a75: [Bazel][mlir] Simplify test/BUILD.bazel with globs
Summary

This reduces the maintenance burden by using globs, which is the
tradeoff we make in the other LLVM Bazel build files as well.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Sep 13 2021, 1:25 PM
Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan and 19 others. · View Herald TranscriptSep 13 2021, 1:25 PM
GMNGeoffrey requested review of this revision.Sep 13 2021, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2021, 1:25 PM
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
GMNGeoffrey added a reviewer: bkramer.Sep 13 2021, 1:25 PM
Harbormaster completed remote builds in B123740: Diff 372333.Sep 13 2021, 1:29 PM
mehdi_amini accepted this revision.Sep 13 2021, 1:43 PM
This revision is now accepted and ready to land.Sep 13 2021, 1:43 PM
Closed by commit rG095bbc3a5a75: [Bazel][mlir] Simplify test/BUILD.bazel with globs (authored by GMNGeoffrey). · Explain WhySep 13 2021, 1:45 PM
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rG095bbc3a5a75: [Bazel][mlir] Simplify test/BUILD.bazel with globs.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
mlir/
test/
37 lines

Diff 372333

utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel

Show All 27 Lines deps = [
"//mlir:MemRefDialect", "//mlir:MemRefDialect",
"//mlir:Pass", "//mlir:Pass",
"//mlir:Support", "//mlir:Support",
], ],
) )
td_library( td_library(
name = "TestOpTdFiles", name = "TestOpTdFiles",
srcs = [ srcs = glob(["lib/Dialect/Test/*.td"]),
"lib/Dialect/Test/TestInterfaces.td",
"lib/Dialect/Test/TestOps.td",
"//mlir:include/mlir/Dialect/DLTI/DLTIBase.td",
"//mlir:include/mlir/IR/OpAsmInterface.td",
"//mlir:include/mlir/IR/RegionKindInterface.td",
"//mlir:include/mlir/IR/SymbolInterfaces.td",
"//mlir:include/mlir/Interfaces/CallInterfaces.td",
"//mlir:include/mlir/Interfaces/ControlFlowInterfaces.td",
"//mlir:include/mlir/Interfaces/CopyOpInterface.td",
"//mlir:include/mlir/Interfaces/DataLayoutInterfaces.td",
"//mlir:include/mlir/Interfaces/InferTypeOpInterface.td",
],
deps = [ deps = [
"//mlir:CallInterfacesTdFiles",
"//mlir:ControlFlowInterfacesTdFiles",
"//mlir:CopyOpInterfaceTdFiles",
"//mlir:DLTIDialectTdFiles",
"//mlir:DataLayoutInterfacesTdFiles",
"//mlir:InferTypeOpInterfaceTdFiles",
"//mlir:OpBaseTdFiles", "//mlir:OpBaseTdFiles",
"//mlir:SideEffectTdFiles", "//mlir:SideEffectTdFiles",
], ],
) )
gentbl_cc_library( gentbl_cc_library(
name = "TestOpsIncGen", name = "TestOpsIncGen",
strip_include_prefix = "lib/Dialect/Test", strip_include_prefix = "lib/Dialect/Test",
▲ Show 20 Lines • Show All 133 Lines • ▼ Show 20 Linesgentbl_cc_library(
deps = [ deps = [
":TestOpTdFiles", ":TestOpTdFiles",
"//mlir:BuiltinDialectTdFiles", "//mlir:BuiltinDialectTdFiles",
], ],
) )
cc_library( cc_library(
name = "TestDialect", name = "TestDialect",
srcs = [ srcs = glob(["lib/Dialect/Test/*.cpp"]),
"lib/Dialect/Test/TestAttributes.cpp", hdrs = glob(["lib/Dialect/Test/*.h"]),
"lib/Dialect/Test/TestDialect.cpp",
"lib/Dialect/Test/TestInterfaces.cpp",
"lib/Dialect/Test/TestPatterns.cpp",
"lib/Dialect/Test/TestTraits.cpp",
"lib/Dialect/Test/TestTypes.cpp",
],
hdrs = [
"lib/Dialect/Test/TestAttributes.h",
"lib/Dialect/Test/TestDialect.h",
"lib/Dialect/Test/TestInterfaces.h",
"lib/Dialect/Test/TestTraits.h",
"lib/Dialect/Test/TestTypes.h",
],
includes = [ includes = [
"lib/Dialect/Test", "lib/Dialect/Test",
], ],
deps = [ deps = [
":TestAttrDefsIncGen", ":TestAttrDefsIncGen",
":TestInterfacesIncGen", ":TestInterfacesIncGen",
":TestOpsIncGen", ":TestOpsIncGen",
":TestTypeDefsIncGen", ":TestTypeDefsIncGen",
▲ Show 20 Lines • Show All 306 Lines • Show Last 20 Lines