This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Fix test relying on incompatible attributes
ClosedPublic

Authored by arsenm on Sep 13 2021, 9:51 AM.

Details

Summary

This combination of amdgpu-waves-per-eu and
amdgpu-flat-work-group-size cannot be satisfied at the same time, so
this was using the default.

Diff Detail

Event Timeline

arsenm created this revision.Sep 13 2021, 9:51 AM
arsenm requested review of this revision.Sep 13 2021, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2021, 9:51 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm updated this revision to Diff 373223.Sep 17 2021, 8:03 AM

Add test, although it's hard to directly observe this. Also add some documentation

rampitec added inline comments.Sep 20 2021, 3:34 PM
llvm/docs/AMDGPUUsage.rst
872 ↗(On Diff #373223)

This needs reformat to keep column width.

arsenm updated this revision to Diff 373728.Sep 20 2021, 3:38 PM

Correct patch

rampitec accepted this revision.Sep 20 2021, 3:46 PM

A test only NFC change? LGTM anyway.

This revision is now accepted and ready to land.Sep 20 2021, 3:46 PM