[analyzer] check for std::__addressof for inner pointer checker

[steakhal]

Summary

This is an extension to diff D99260. This adds an additional exception for std::__addressof in InnerPointerChecker.

Originally authored by alishuja (Ali Shuja Siddiqui).

[NoQ]

Thanks! Can you add a regression test for this, like D99260 does in test/Analysis/inner-pointer.cpp? We typically want all commits to have associated test cases.

[steakhal]

I'll finish this one.

[steakhal]

• rebased (now using matchesAny(...)
• added a test

[martong]

LGTM

[steakhal]

@alishuja, Shall I submit this patch with --author="Ali Shuja Siddiqui <[e-mail]>" (thus on your behalf) ?
The LLVM DeveloperPolicy mandates me for asking permission.

[alishuja]

@steakhal yes please go ahead, thank you.

clang/lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp

 class InnerPointerChecker
     : public Checker<check::DeadSymbols, check::PostCall> {
 
-  CallDescription AppendFn, AssignFn, AddressofFn, ClearFn, CStrFn, DataFn,
-      DataMemberFn, EraseFn, InsertFn, PopBackFn, PushBackFn, ReplaceFn,
-      ReserveFn, ResizeFn, ShrinkToFitFn, SwapFn;
+  CallDescription AppendFn, AssignFn, AddressofFn, AddressofFn_, ClearFn,
+      CStrFn, DataFn, DataMemberFn, EraseFn, InsertFn, PopBackFn, PushBackFn,
+      ReplaceFn, ReserveFn, ResizeFn, ShrinkToFitFn, SwapFn;
 
 public:
   class InnerPointerBRVisitor : public BugReporterVisitor {

   InnerPointerChecker()
       : AppendFn({"std", "basic_string", "append"}),
         AssignFn({"std", "basic_string", "assign"}),
-        AddressofFn({"std", "addressof"}),
+        AddressofFn({"std", "addressof"}), AddressofFn_({"std", "__addressof"}),
         ClearFn({"std", "basic_string", "clear"}),
         CStrFn({"std", "basic_string", "c_str"}), DataFn({"std", "data"}, 1),
         DataMemberFn({"std", "basic_string", "data"}),

 
       // std::addressof function accepts a non-const reference as an argument,
       // but doesn't modify it.
-      if (Call.isCalled(AddressofFn))
+      if (Call.isCalled(AddressofFn) || Call.isCalled(AddressofFn_))
         continue;
 
       markPtrSymbolsReleased(Call, State, ArgRegion, C);