This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix GPU LaunchFunc conversion to the LLVM dialect
ClosedPublic

Authored by ftynse on Sep 7 2021, 5:28 AM.

Details

Summary

The conversion has been incorrectly using the operands of the original
operation instead of the converted operands provided to the matchAndRewrite
call. This may lead to spurious materializations and generally invalid IR if
the producer of the original operands is deleted in the process of conversion.

Diff Detail

Event Timeline

ftynse created this revision.Sep 7 2021, 5:28 AM
ftynse requested review of this revision.Sep 7 2021, 5:28 AM
csigg accepted this revision.Sep 7 2021, 5:58 AM
This revision is now accepted and ready to land.Sep 7 2021, 5:58 AM
This revision was automatically updated to reflect the committed changes.