This patch adds Big-Endian checks for the existing MMA test cases.
It also changes the target for these test cases to pwr10.
Details
- Reviewers
nemanjai lei - Group Reviewers
Restricted Project - Commits
- rG203cd01b54dd: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/test/CodeGen/builtins-ppc-pair-mma.c | ||
---|---|---|
5 | Seems just adding %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 -emit-llvm %s -o - | FileCheck %s also makes the test pass. CHECK and CHECK-BE contents are the same. |
LGTM. Please update the description and commit message as to why this is being added.
clang/test/CodeGen/builtins-ppc-pair-mma.c | ||
---|---|---|
5 | The existing builtins produce the same IR but I think this is done in preparation for https://reviews.llvm.org/D107647 which will add builtins very similar to these but that produce different IR on LE and BE. The description of the patch should probably mention that. |
Is it really necessary to add the BE checks in this patch if they are the same as LE checks? Why not just add it later when there is a diff seen?
clang/test/CodeGen/builtins-ppc-pair-mma.c | ||
---|---|---|
5 | Since all the builtins in this file produce the same output for LE and BE, it's probably better to add checks for the new builtins (having different output for LE/BE) in a separate file. |
Seems just adding %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 -emit-llvm %s -o - | FileCheck %s also makes the test pass. CHECK and CHECK-BE contents are the same.