This is an archive of the discontinued LLVM Phabricator instance.

[mlir][SCF] Canonicalize dim(x) where x is an iter_arg
ClosedPublic

Authored by springerm on Aug 26 2021, 11:53 PM.

Details

Summary
  • Add DimOfIterArgFolder.
  • Move existing cross-dialect canonicalization patterns to LoopCanonicalization.cpp.
  • Rename SCFAffineOpCanonicalization pass to SCFForLoopCanonicalization.
  • Expand documentaton of scf.for: The type of loop-carried variables may not change with iterations. (Not even the dynamic type.)

Diff Detail

Event Timeline

springerm created this revision.Aug 26 2021, 11:53 PM
springerm requested review of this revision.Aug 26 2021, 11:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2021, 11:53 PM
ftynse accepted this revision.Aug 27 2021, 12:13 AM
ftynse added inline comments.
mlir/lib/Dialect/SCF/Transforms/PassDetail.h
27

Please fix the linter warning.

This revision is now accepted and ready to land.Aug 27 2021, 12:13 AM
springerm updated this revision to Diff 369356.Aug 29 2021, 6:12 PM

address comments

This revision was landed with ongoing or failed builds.Aug 29 2021, 6:40 PM
This revision was automatically updated to reflect the committed changes.