The emplace commands are variadic and should take all the constructor arguments directly, since they implicitly call the constructor themselves in order to avoid the cost of constructing and then moving/copying temporaries.
Details
Details
Summary
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Herald added subscribers: Chia-hungDuan, dcaballe, cota and 16 others. · View Herald TranscriptAug 24 2021, 3:49 PM
This revision is now accepted and ready to land.Aug 24 2021, 4:09 PM
wrengr retitled this revision from Correcting the use of emplace_back to [mlir][sparse] Correcting the use of emplace_back.Aug 24 2021, 6:16 PM
Closed by commit rG90e0c657b7cb: [mlir][sparse] Correcting the use of emplace_back (authored by wrengr). · Explain WhyAug 24 2021, 6:32 PM
This revision was automatically updated to reflect the committed changes.