Page MenuHomePhabricator
Differential D108593

[mlir][AttrTypeGen] Add support for specifying a "accessor" type of a parameter
ClosedPublic
Actions

Authored by rriddle on Aug 23 2021, 3:43 PM.

Details

Reviewers
jpienaar
antiagainst
Commits
rGc8d9e1ce43a7: [mlir][AttrTypeGen] Add support for specifying a "accessor" type of a parameter
Summary

This allows for using a different type when accessing a parameter than the
one used for storage. This allows for returning parameters by reference,
enables using more optimized/convient reference results, and more.

Depends On D108589

Diff Detail

Event Timeline

rriddle created this revision.Aug 23 2021, 3:43 PM
Herald added a reviewer: antiagainst. · View Herald TranscriptAug 23 2021, 3:43 PM
Herald added subscribers: wrengr, Chia-hungDuan, dcaballe and 18 others. · View Herald Transcript
rriddle requested review of this revision.Aug 23 2021, 3:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2021, 3:43 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B120876: Diff 368226.Aug 23 2021, 4:21 PM
jpienaar accepted this revision.Aug 23 2021, 5:38 PM
This revision is now accepted and ready to land.Aug 23 2021, 5:38 PM
Closed by commit rGc8d9e1ce43a7: [mlir][AttrTypeGen] Add support for specifying a "accessor" type of a parameter (authored by rriddle). · Explain WhyAug 25 2021, 2:38 AM
This revision was automatically updated to reflect the committed changes.
rriddle added a commit: rGc8d9e1ce43a7: [mlir][AttrTypeGen] Add support for specifying a "accessor" type of a parameter.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
IR/
10 lines
TableGen/
3 lines
lib/
TableGen/
9 lines
test/
mlir-tblgen/
11 lines
tools/
mlir-tblgen/
5 lines

Diff 368226

View Options

mlir/include/mlir/IR/OpBase.td

Loading...
View Options

mlir/include/mlir/TableGen/AttrOrTypeDef.h

Loading...
View Options

mlir/lib/TableGen/AttrOrTypeDef.cpp

Loading...
View Options

mlir/test/mlir-tblgen/attrdefs.td

Loading...
View Options

mlir/tools/mlir-tblgen/AttrOrTypeDefGen.cpp

Loading...