This is an archive of the discontinued LLVM Phabricator instance.

Differential D108369

[mlir][linalg] Fix __repr__ implementation in const from opdsl
ClosedPublic

Authored by shabalin on Aug 19 2021, 5:32 AM.

Details

Reviewers
gysit
Commits
rG1631d9a7ea1a: [mlir][linalg] Fix __repr__ implementation in const from opdsl

Diff Detail

Event Timeline

shabalin created this revision.Aug 19 2021, 5:32 AM
Herald added subscribers: wrengr, Chia-hungDuan, dcaballe and 18 others. · View Herald TranscriptAug 19 2021, 5:32 AM
shabalin requested review of this revision.Aug 19 2021, 5:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2021, 5:32 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
shabalin added a reviewer: gysit.Aug 19 2021, 5:36 AM
shabalin retitled this revision from Fix __str__ implementation in const from opdsl to Fix __repr__ implementation in const from opdsl.
gysit accepted this revision.Aug 19 2021, 5:38 AM

Thanks for fixing!

This revision is now accepted and ready to land.Aug 19 2021, 5:38 AM
shabalin updated this revision to Diff 367483.Aug 19 2021, 6:31 AM

Fix commit message.

shabalin updated this revision to Diff 367484.Aug 19 2021, 6:36 AM

Add [mlir][linalg] prefix to the commit message

shabalin retitled this revision from Fix __repr__ implementation in const from opdsl to [mlir][linalg] Fix __repr__ implementation in const from opdsl.Aug 19 2021, 6:36 AM
Herald added a subscriber: limo1996. · View Herald TranscriptAug 19 2021, 6:36 AM
Harbormaster completed remote builds in B120323: Diff 367484.Aug 19 2021, 7:24 AM
Closed by commit rG1631d9a7ea1a: [mlir][linalg] Fix __repr__ implementation in const from opdsl (authored by shabalin, committed by ftynse). · Explain WhyAug 20 2021, 3:40 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG1631d9a7ea1a: [mlir][linalg] Fix __repr__ implementation in const from opdsl.

Revision Contents

PathSize
mlir/
python/
mlir/
dialects/
linalg/
opdsl/
lang/
2 lines

Diff 367484

mlir/python/mlir/dialects/linalg/opdsl/lang/comprehension.py

Show First 20 Lines • Show All 399 Lines • ▼ Show 20 Lines with _ir.Context():
_ir.IntegerAttr.get(_ir.IntegerType.get_signless(64), int(value))) _ir.IntegerAttr.get(_ir.IntegerType.get_signless(64), int(value)))
else: else:
raise ValueError(f"const requires int or float but got {type(value)}") raise ValueError(f"const requires int or float but got {type(value)}")
def to_scalar_expression(self) -> ScalarExpression: def to_scalar_expression(self) -> ScalarExpression:
return ScalarConst(self.value).expr() return ScalarConst(self.value).expr()
def __repr__(self): def __repr__(self):
return f"const({self.type_var}, {self.value})" return f"const({self.value})"
class index(TensorExpression): class index(TensorExpression):
"""Returns the iteration index for a given dimension name. """Returns the iteration index for a given dimension name.
Resolves the given dimension name to obtain its position in the iteration Resolves the given dimension name to obtain its position in the iteration
domain of the operation. domain of the operation.
""" """
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines