[clang][openmp] Disable embedded elf notes

[JonChesterfield]

Summary

D99551 broke nvptx offloading. This patch
fixes that by disabling the functional change of
D99551, allowing time to fix it without excessive
out of tree churn

[vzakhari]

Hi Jon, I am about to merge D108246 that disables the notes embedding.

[JonChesterfield]

I like D108246 more. None of the offloading tests updated in D108246 failed with the above patch, perhaps they're not run by make check-openmp

edit: all good, they're under check-clang, which does indeed fail with this patch

[vzakhari]

In D108303#2952393, @JonChesterfield wrote:

I like D108246 more. None of the offloading tests updated in D108246 failed with the above patch, perhaps they're not run by make check-openmp

Right, the clang-offload-wrapper test is run by check-clang.

clang/tools/clang-offload-wrapper/ClangOffloadWrapper.cpp

#endif
 
     return std::move(*BufOrErr);
   }
 };
 
 } // anonymous namespace
 
 int main(int argc, const char **argv) {
+  // Embedded elf notes does not work on nvptx, disabling it globally while
+  // a fix is worked on offline
+  const bool EmbedElfNotes = false;
   sys::PrintStackTraceOnErrorSignal(argv[0]);
 
   cl::HideUnrelatedOptions(ClangOffloadWrapperCategory);
   cl::SetVersionPrinter([](raw_ostream &OS) {
     OS << clang::getClangToolFullVersion("clang-offload-wrapper") << '\n';
   });
   cl::ParseCommandLineOptions(
       argc, argv,
int main(int argc, const char **argv) {
   for (const std::string &File : Inputs) {
     ErrorOr<std::unique_ptr<MemoryBuffer>> BufOrErr =
         MemoryBuffer::getFileOrSTDIN(File);
     if (!BufOrErr) {
       reportError(createFileError(File, BufOrErr.getError()));
       return 1;
     }
     std::unique_ptr<MemoryBuffer> Buffer(std::move(*BufOrErr));
-    if (File != "-") {
+    if (EmbedElfNotes && File != "-") {
       // Adding ELF notes for STDIN is not supported yet.
       Buffer = Wrapper.addELFNotes(std::move(Buffer), File);
     }
     const std::unique_ptr<MemoryBuffer> &Buf =
         Buffers.emplace_back(std::move(Buffer));
     Images.emplace_back(Buf->getBufferStart(), Buf->getBufferSize());
   }