Page MenuHomePhabricator

[clang][openmp] Disable embedded elf notes
AbandonedPublic

Authored by JonChesterfield on Aug 18 2021, 8:06 AM.

Details

Summary

D99551 broke nvptx offloading. This patch
fixes that by disabling the functional change of
D99551, allowing time to fix it without excessive
out of tree churn

Diff Detail

Unit TestsFailed

TimeTest
60 msx64 debian > Clang.Driver::clang-offload-wrapper.c
Script: -- : 'RUN: at line 6'; clang-offload-wrapper --help | /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/clang/test/Driver/clang-offload-wrapper.c --check-prefix CHECK-HELP
110 msx64 windows > Clang.Driver::clang-offload-wrapper.c
Script: -- : 'RUN: at line 6'; clang-offload-wrapper --help | c:\ws\w5\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w5\llvm-project\premerge-checks\clang\test\Driver\clang-offload-wrapper.c --check-prefix CHECK-HELP

Event Timeline

JonChesterfield requested review of this revision.Aug 18 2021, 8:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 18 2021, 8:06 AM

Hi Jon, I am about to merge D108246 that disables the notes embedding.

JonChesterfield abandoned this revision.EditedAug 18 2021, 8:11 AM

I like D108246 more. None of the offloading tests updated in D108246 failed with the above patch, perhaps they're not run by make check-openmp

edit: all good, they're under check-clang, which does indeed fail with this patch

I like D108246 more. None of the offloading tests updated in D108246 failed with the above patch, perhaps they're not run by make check-openmp

Right, the clang-offload-wrapper test is run by check-clang.