This is an archive of the discontinued LLVM Phabricator instance.

Differential D108057

[Flang] Add compiled python modules to .gitignore
AcceptedPublic

Authored by kiranchandramohan on Aug 13 2021, 2:04 PM.

Details

Reviewers
Meinersbur
awarzynski
klausler
Summary

We recently started using python to run some tests. The usage of a
common shared file creates compiled python modules in pycache
directory. Ignore this and any other compiled python files.

Diff Detail

Event Timeline

kiranchandramohan requested review of this revision.Aug 13 2021, 2:04 PM
kiranchandramohan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2021, 2:04 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
kiranchandramohan mentioned this in D107041: [Flang] Ported test_symbols to Python.Aug 13 2021, 2:06 PM
Harbormaster completed remote builds in B119504: Diff 366353.Aug 13 2021, 2:31 PM
awarzynski mentioned this in D108023: [flang][lit] Introduce `%python_b` in LIT configuration.Aug 14 2021, 2:06 AM
Meinersbur added a comment.Aug 18 2021, 8:53 AM

The patch should not do harm and seems to be useful to some, so I am approving it. Although I think it is redundant (that is, most of the entries in this file) with what the top-level .gitignore already contains.

flang/.gitignore
26

Adding a trailing / indicates to git to apply the rules to directories.

Meinersbur accepted this revision.Sep 13 2021, 10:44 AM

Seems I forgot to actually select accept from the drop-down manu.

This revision is now accepted and ready to land.Sep 13 2021, 10:44 AM
MehdiChinoune added a project: Restricted Project.Sep 15 2021, 11:48 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptSep 15 2021, 11:48 AM
klausler resigned from this revision.Feb 8 2023, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 2:31 PM
Herald added a subscriber: sunshaoce. · View Herald Transcript

Revision Contents

PathSize
flang/
6 lines

Diff 366353

flang/.gitignore

#==============================================================================#
# This file specifies intentionally untracked files that git should ignore.
#==============================================================================#
Debug Debug
Release Release
MinSizeRel MinSizeRel
build build
root root
tags tags
TAGS TAGS
*.o *.o
.nfs* .nfs*
*.sw? *.sw?
*~ *~
*# *#
CMakeCache.txt CMakeCache.txt
*/CMakeFiles/* */CMakeFiles/*
*/*/CMakeFiles/* */*/CMakeFiles/*
*/Makefile */Makefile
*/*/Makefile */*/Makefile
cmake_install.cmake cmake_install.cmake
formatted formatted
.DS_Store .DS_Store
.vs_code .vs_code
# Byte compiled python modules.
__pycache__
MeinersburUnsubmitted
Not Done
ReplyInline Actions
# Byte compiled python modules.
- __pycache__
+ __pycache__/
*.pyc

Adding a trailing / indicates to git to apply the rules to directories.

Meinersbur: Adding a trailing `/` indicates to git to apply the rules to directories.
*.pyc