This is an archive of the discontinued LLVM Phabricator instance.

ReleaseNotes: add lld/ELF notes
ClosedPublic

Authored by MaskRay on Aug 9 2021, 2:02 PM.

Details

Summary

For the release/13.x branch.

Diff Detail

Event Timeline

MaskRay created this revision.Aug 9 2021, 2:02 PM
MaskRay requested review of this revision.Aug 9 2021, 2:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2021, 2:02 PM

Everything that's added in here LGTM. I haven't been keeping up with LLD enough to say if there's other things worth including as well :)

Some grammar suggestions from me. As with @smeenai, I've not been following development closely enough to confirm that these are all the changes that should be documented though.

lld/docs/ReleaseNotes.rst
44
47
53
55
62

I think this is what is meant?

Also should this and the other linker-script related changes have a note saying they are for linker scripts (e.g. in this case "in the linker script output section description ...")?

81
87
89
97
99
MaskRay updated this revision to Diff 366719.Aug 16 2021, 12:47 PM
MaskRay marked 9 inline comments as done.

Appreciate the grammar suggestions :)

lld/docs/ReleaseNotes.rst
62

Also should this and the other linker-script related changes have a note saying they are for linker scripts (e.g. in this case "in the linker script output section description ...")?

Thanks for the suggestion. Applied

MaskRay marked an inline comment as done.Aug 16 2021, 12:48 PM
jhenderson added inline comments.Aug 17 2021, 12:31 AM
lld/docs/ReleaseNotes.rst
75

Perhaps worth being specific by what you mean by "quotes". At least in British English, quotes can mean both ' and " (single and double quotes respectively). When just the term "quotes" is mentioned, it can be ambiguous without context.

MaskRay updated this revision to Diff 366927.Aug 17 2021, 9:43 AM
MaskRay marked an inline comment as done.

quotes -> double quotes

MaskRay accepted this revision.EditedAug 17 2021, 9:45 AM

Thanks! Pushed to release/13.x

This revision is now accepted and ready to land.Aug 17 2021, 9:45 AM
MaskRay closed this revision.Aug 17 2021, 9:45 AM