This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Analysis][NFC] Reimplement FlatAffineConstraints::addLowerOrUpperBound
ClosedPublic

Authored by springerm on Aug 8 2021, 11:04 PM.

Details

Summary

Reimplement this function in terms of the function variant without Value semantics.

Depends On D107727

Diff Detail

Event Timeline

springerm created this revision.Aug 8 2021, 11:04 PM
springerm requested review of this revision.Aug 8 2021, 11:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2021, 11:04 PM
ftynse accepted this revision.Aug 9 2021, 8:45 AM
ftynse added inline comments.
mlir/lib/Analysis/AffineStructures.cpp
2097
2103–2104

Nit: please add assertion messages.

This revision is now accepted and ready to land.Aug 9 2021, 8:45 AM
springerm retitled this revision from [mlir][Analysis][NFC] Reimplement FlatAffineValueConstraints::addLowerOrUpperBound to [mlir][Analysis][NFC] Reimplement FlatAffineConstraints::addLowerOrUpperBound.Aug 10 2021, 4:47 AM
springerm edited the summary of this revision. (Show Details)
springerm marked 2 inline comments as done.
This revision was landed with ongoing or failed builds.Aug 10 2021, 11:26 PM
This revision was automatically updated to reflect the committed changes.