This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Include llvm/Support/Debug.h in Transforms/Passes.h
ClosedPublic

Authored by springerm on Aug 4 2021, 5:37 AM.

Details

Summary

There are many downstream users of llvm::dbgs, which is defined in Debug.h. Before D106342, many users included that dependency transitively via the now deleted ViewRegionGraph.h. Adding it back to Transforms/Passes.h for convenience.

Diff Detail

Event Timeline

springerm created this revision.Aug 4 2021, 5:37 AM
springerm requested review of this revision.Aug 4 2021, 5:37 AM
akuegel accepted this revision.Aug 4 2021, 5:38 AM

Thanks :)

This revision is now accepted and ready to land.Aug 4 2021, 5:38 AM
This revision was landed with ongoing or failed builds.Aug 4 2021, 5:47 AM
This revision was automatically updated to reflect the committed changes.

Can you instead move the include to those users? I don't think Transforms.h should need to include Debug.h.

Can you instead move the include to those users? I don't think Transforms.h should need to include Debug.h.

Yes, this was just the fastest way to fix the build yesterday. Preparing a commit that includes the file in each user...