[analyzer] Fix deprecated plistlib functions

[manas]

Summary

It replaces the usage of readPlist,writePlist functions with load,dump
in plistlib package.

This fixes deprecation issues when analyzer reports are being generated
outside of docker.

[manas]

Gentle ping.

[steakhal]

I'm not using this script. I'm assuming you run it and verified that it works.
Thanks for cleaning this up.

[manas]

In D107312#3036421, @steakhal wrote:

I'm not using this script. I'm assuming you run it and verified that it works.
Thanks for cleaning this up.

I have run it. It is working.

clang/utils/analyzer/SATestBuild.py

def normalize_reference_results(directory: str, output_dir: str,
     Make the absolute paths relative in the reference results.
     """
     for dir_path, _, filenames in os.walk(output_dir):
         for filename in filenames:
             if not filename.endswith('plist'):
                 continue
 
             plist = os.path.join(dir_path, filename)
-            data = plistlib.readPlist(plist)
+            with open(plist, "rb") as plist_file:
+                data = plistlib.load(plist_file)
             path_prefix = directory
 
             if build_mode == 1:
                 path_prefix = os.path.join(directory, PATCHED_SOURCE_DIR_NAME)
 
             paths = [source[len(path_prefix) + 1:]
                      if source.startswith(path_prefix) else source
                      for source in data['files']]
             data['files'] = paths
 
             # Remove transient fields which change from run to run.
             for diagnostic in data['diagnostics']:
                 if 'HTMLDiagnostics_files' in diagnostic:
                     diagnostic.pop('HTMLDiagnostics_files')
 
             if 'clang_version' in data:
                 data.pop('clang_version')
 
-            plistlib.writePlist(data, plist)
+            with open(plist, "wb") as plist_file:
+                plistlib.dump(data, plist_file)
 
 
 def get_build_log_path(output_dir: str) -> str:
     return os.path.join(output_dir, LOG_DIR_NAME, BUILD_LOG_NAME)
 
 
 def remove_log_file(output_dir: str):
     build_log_path = get_build_log_path(output_dir)