[analyzer] Add option to SATest.py for extra checkers

[RedDocMD]

Summary

This patch adds the flag extra-checkers to the sub-command build for
passing a comma separated list of additional checkers to include.

[RedDocMD]

It turns out that there is already an option called extra-analyzer-config to pass analyzer configs, like setting ModelSmartPtrDereference to true

[RedDocMD]

@vsavchenko is this okay?

[vsavchenko]

Looks good! Thanks!

[ASDenysPetrov]

@RedDocMD Could you, please, explain the motivation and add at least one test to verify it works.

[RedDocMD]

In D106739#2907647, @ASDenysPetrov wrote:

@RedDocMD Could you, please, explain the motivation and add at least one test to verify it works.

Motivation: I need to run these projects with the SmartPtrChecker enabled (which is an alpha checker, hence not enabled by default).
Test: This is more of a helper script, not a core library, so I think we can be a little relaxed with the testing thing.

clang/utils/analyzer/SATest.py

def build(parser, args):
 
     SATestBuild.VERBOSE = args.verbose
 
     projects = get_projects(parser, args)
     tester = SATestBuild.RegressionTester(args.jobs,
                                           projects,
                                           args.override_compiler,
                                           args.extra_analyzer_config,
+                                          args.extra_checkers,
                                           args.regenerate,
                                           args.strictness)
     tests_passed = tester.test_all()
 
     if not tests_passed:
         sys.stderr.write("ERROR: Tests failed.\n")
         sys.exit(42)
 
build_parser.add_argument("--override-compiler", action="store_true",
                               "--override-compiler option.")
     build_parser.add_argument("-j", "--jobs", dest="jobs",
                               type=int, default=0,
                               help="Number of projects to test concurrently")
     build_parser.add_argument("--extra-analyzer-config",
                               dest="extra_analyzer_config", type=str,
                               default="",
                               help="Arguments passed to to -analyzer-config")
+    build_parser.add_argument("--extra-checkers",
+                              dest="extra_checkers", type=str,
+                              default="",
+                              help="Extra checkers to enable")
     build_parser.add_argument("--projects", action="store", default="",
                               help="Comma-separated list of projects to test")
     build_parser.add_argument("--max-size", action="store", default=None,
                               help="Maximum size for the projects to test")
     build_parser.add_argument("-v", "--verbose", action="count", default=0)
     build_parser.set_defaults(func=build)
 
     # compare subcommand

clang/utils/analyzer/SATestBuild.py

 
 class TestInfo(NamedTuple):
     """
     Information about a project and settings for its analysis.
     """
     project: ProjectInfo
     override_compiler: bool = False
     extra_analyzer_config: str = ""
+    extra_checkers: str = ""
     is_reference_build: bool = False
     strictness: int = 0
 
 
 # typing package doesn't have a separate type for Queue, but has a generic stub
 # We still want to have a type-safe checked project queue, for this reason,
 # we specify generic type for mypy.
 #
 # It is a common workaround for this situation:
 # https://mypy.readthedocs.io/en/stable/common_issues.html#using-classes-that-are-generic-in-stubs-but-not-at-runtime
 if TYPE_CHECKING:
     TestQueue = Queue[TestInfo]  # this is only processed by mypy
 else:
     TestQueue = Queue  # this will be executed at runtime
 
 
 class RegressionTester:
     """
     A component aggregating all of the project testing.
     """
+
     def __init__(self, jobs: int, projects: List[ProjectInfo],
                  override_compiler: bool, extra_analyzer_config: str,
+                 extra_checkers: str,
                  regenerate: bool, strictness: bool):
         self.jobs = jobs
         self.projects = projects
         self.override_compiler = override_compiler
         self.extra_analyzer_config = extra_analyzer_config
+        self.extra_checkers = extra_checkers
         self.regenerate = regenerate
         self.strictness = strictness
 
     def test_all(self) -> bool:
         projects_to_test: List[TestInfo] = []
 
         # Test the projects.
         for project in self.projects:
             projects_to_test.append(
                 TestInfo(project,
                          self.override_compiler,
                          self.extra_analyzer_config,
+                         self.extra_checkers,
                          self.regenerate, self.strictness))
         if self.jobs <= 1:
             return self._single_threaded_test_all(projects_to_test)
         else:
             return self._multi_threaded_test_all(projects_to_test)
 
     def _single_threaded_test_all(self,
                                   projects_to_test: List[TestInfo]) -> bool:
def _multi_threaded_test_all(self,
                 sys.exit(1)
         return not results_differ.is_set()
 
 
 class ProjectTester:
     """
     A component aggregating testing for one project.
     """
+
     def __init__(self, test_info: TestInfo, silent: bool = False):
         self.project = test_info.project
         self.override_compiler = test_info.override_compiler
         self.extra_analyzer_config = test_info.extra_analyzer_config
+        self.extra_checkers = test_info.extra_checkers
         self.is_reference_build = test_info.is_reference_build
         self.strictness = test_info.strictness
         self.silent = silent
 
     def test(self) -> bool:
         """
         Test a given project.
         :return tests_passed: Whether tests have passed according
def scan_build(self, directory: str, output_dir: str,
             stderr(f"Error: build script is not defined: "
                    f"{build_script_path}\n")
             sys.exit(1)
 
         all_checkers = CHECKERS
         if 'SA_ADDITIONAL_CHECKERS' in os.environ:
             all_checkers = (all_checkers + ',' +
                             os.environ['SA_ADDITIONAL_CHECKERS'])
+        if self.extra_checkers != "":
+            all_checkers += "," + self.extra_checkers
 
         # Run scan-build from within the patched source directory.
         cwd = os.path.join(directory, PATCHED_SOURCE_DIR_NAME)
 
         options = f"--use-analyzer '{CLANG}' "
         options += f"-plist-html -o '{output_dir}' "
         options += f"-enable-checker {all_checkers} "
         options += "--keep-empty "