We want to parse the -b option in the driver and pass it to the linker if the target OS is AIX. This will establish compatibility with the other AIX compilers.
Can this be reversed so the error check is first for (!T.isOSAIX()) instead? Then you don't need the else.
Does this mean that we need space between -b and the linker option when using clang normally? Or this an artifact of the way we need to write tests?
I see, that makes sense.
But now with your patch this option is supported even if only for the AIX target. So we could make the case to use the suggested error message. That said, I am still fine with what you choose.
I actually agree on your point. So, eventhough my intention was to leave the behavior on other (non-AIX) platforms unaffected, the change causes the behavior of the option to be more target-specific - since it's now valid/supported option on AIX. So, I am going to change this error message as suggested. Thanks!