Page MenuHomePhabricator
People anjankgk

anjankgk (Anjan Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2020, 6:56 AM (150 w, 5 d)

Recent Activity
View All

Jul 30 2021

anjankgk committed rGaa35c496cf53: [AIX] Pass the -b option to linker on AIX (with fix to build break) (authored by anjankgk).
[AIX] Pass the -b option to linker on AIX (with fix to build break)
Jul 30 2021, 8:53 AM
anjankgk closed D107105: [AIX] Pass the -b option to linker on AIX (with fix to build break).
Jul 30 2021, 8:52 AM · Restricted Project

Jul 29 2021

anjankgk requested review of D107105: [AIX] Pass the -b option to linker on AIX (with fix to build break).
Jul 29 2021, 2:20 PM · Restricted Project
anjankgk added a reverting change for rG109954410c34: [AIX] Pass the -b option to linker on AIX: rG7645cdcb4826: Revert "[AIX] Pass the -b option to linker on AIX".
Jul 29 2021, 12:41 PM
anjankgk committed rG7645cdcb4826: Revert "[AIX] Pass the -b option to linker on AIX" (authored by anjankgk).
Revert "[AIX] Pass the -b option to linker on AIX"
Jul 29 2021, 12:41 PM
anjankgk added a reverting change for D106688: [AIX] Pass the -b option to linker on AIX: rG7645cdcb4826: Revert "[AIX] Pass the -b option to linker on AIX".
Jul 29 2021, 12:41 PM · Restricted Project
anjankgk committed rG109954410c34: [AIX] Pass the -b option to linker on AIX (authored by anjankgk).
[AIX] Pass the -b option to linker on AIX
Jul 29 2021, 11:15 AM
anjankgk closed D106688: [AIX] Pass the -b option to linker on AIX.
Jul 29 2021, 11:15 AM · Restricted Project

Jul 28 2021

anjankgk updated the diff for D106688: [AIX] Pass the -b option to linker on AIX.

Change the error msg to include target information.

Jul 28 2021, 9:08 PM · Restricted Project
anjankgk added inline comments to D106688: [AIX] Pass the -b option to linker on AIX.
Jul 28 2021, 9:07 PM · Restricted Project
anjankgk added a comment to D106688: [AIX] Pass the -b option to linker on AIX.

Thank you reviewing Zarko!

Jul 28 2021, 12:38 PM · Restricted Project
anjankgk added inline comments to D106688: [AIX] Pass the -b option to linker on AIX.
Jul 28 2021, 8:50 AM · Restricted Project
anjankgk updated the diff for D106688: [AIX] Pass the -b option to linker on AIX.

Addressed review comments

Jul 28 2021, 8:49 AM · Restricted Project

Jul 27 2021

anjankgk added a reviewer for D106688: [AIX] Pass the -b option to linker on AIX: ZarkoCA.
Jul 27 2021, 1:34 PM · Restricted Project

Jul 26 2021

anjankgk added a comment to D106688: [AIX] Pass the -b option to linker on AIX.

Gentle ping..

Jul 26 2021, 6:56 AM · Restricted Project

Jul 23 2021

anjankgk requested review of D106688: [AIX] Pass the -b option to linker on AIX.
Jul 23 2021, 10:30 AM · Restricted Project

Jul 22 2021

anjankgk added a comment to D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX..

Since Whitny and Chris are busy, I have requested Shimin to commit this in.
Thanks Shimin!

Jul 22 2021, 11:50 AM · Restricted Project
anjankgk added a comment to D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX.

Since Hubert is busy, I have requested Shimin to commit this in.
Thanks Shimin!

Jul 22 2021, 11:50 AM · Restricted Project

Jul 21 2021

anjankgk added a comment to D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX.

Anjan Kumar Guttahalli Krishna <anjankumar.g.k@ca.ibm.com>

Jul 21 2021, 2:53 PM · Restricted Project
anjankgk added a comment to D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX..
In D106074#2893249, @xgupta wrote:

@anjankgk You need to provide your identity for commit in "your name <your email>" form.
see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Prior to obtaining commit access, it is common practice to request that someone with commit access commits on your behalf. When doing so, please provide the name and email address you would like to use in the Author property of the commit.

Jul 21 2021, 9:39 AM · Restricted Project
anjankgk added a comment to D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX..

@cebowleratibm @Whitney Could either of you pls commit this?
Thanks!

Jul 21 2021, 7:16 AM · Restricted Project
anjankgk added a comment to D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX.
In D106371#2892186, @hubert.reinterpretcast wrote:

LGTM with minor nit; thanks.

Jul 21 2021, 7:15 AM · Restricted Project
anjankgk updated the diff for D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX.

Added braces for else-block.

Jul 21 2021, 7:14 AM · Restricted Project

Jul 20 2021

anjankgk requested review of D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX.
Jul 20 2021, 8:44 AM · Restricted Project

Jul 19 2021

anjankgk updated the diff for D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX..

Updated the comment

Jul 19 2021, 2:43 PM · Restricted Project

Jul 16 2021

anjankgk added a comment to D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX..

Thanks for reviewing! Can someone with commit access help commit this pls?
Thanks in advance!

Jul 16 2021, 12:11 PM · Restricted Project

Jul 15 2021

anjankgk requested review of D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX..
Jul 15 2021, 8:55 AM · Restricted Project

May 3 2021

anjankgk added a comment to D88460: Strlen loop idiom recognition.

Gentle ping..

May 3 2021, 9:26 AM · Restricted Project, Restricted Project
anjankgk added a comment to D100496: Add emitWcsLen helper function.

gentle ping for a review request..
Thanks!

May 3 2021, 7:02 AM · Restricted Project, Restricted Project

Apr 19 2021

anjankgk added a comment to D100496: Add emitWcsLen helper function.
In D100496#2698553, @xbolva00 wrote:

Where do you plan to use this new helper?

Apr 19 2021, 7:50 AM · Restricted Project, Restricted Project
anjankgk updated the diff for D100496: Add emitWcsLen helper function.

Add an assert to check the pointer param

Apr 19 2021, 7:07 AM · Restricted Project, Restricted Project

Apr 15 2021

anjankgk added a reviewer for D100496: Add emitWcsLen helper function: lebedev.ri.
Apr 15 2021, 7:15 AM · Restricted Project, Restricted Project
anjankgk updated the diff for D100496: Add emitWcsLen helper function.
Apr 15 2021, 7:13 AM · Restricted Project, Restricted Project

Apr 14 2021

anjankgk added inline comments to D100496: Add emitWcsLen helper function.
Apr 14 2021, 12:12 PM · Restricted Project, Restricted Project
anjankgk requested review of D100496: Add emitWcsLen helper function.
Apr 14 2021, 11:16 AM · Restricted Project, Restricted Project

Apr 6 2021

anjankgk added a reviewer for D88460: Strlen loop idiom recognition: Whitney.
Apr 6 2021, 5:45 AM · Restricted Project, Restricted Project

Apr 5 2021

anjankgk added a comment to D88460: Strlen loop idiom recognition.

I have updated the code based on some more test results and based on the review comments.
Thanks!

Apr 5 2021, 10:21 AM · Restricted Project, Restricted Project
anjankgk updated the diff for D88460: Strlen loop idiom recognition.

Updates from tests and fix to identifying the correct replace instruction from exit BB.

Apr 5 2021, 10:20 AM · Restricted Project, Restricted Project

Jan 12 2021

anjankgk added a comment to D88460: Strlen loop idiom recognition.

Another gentle reminder for the review.. Thanks!

Jan 12 2021, 5:41 AM · Restricted Project, Restricted Project

Jan 4 2021

anjankgk added a comment to D88460: Strlen loop idiom recognition.

Gentle ping...

Jan 4 2021, 10:33 AM · Restricted Project, Restricted Project

Dec 18 2020

anjankgk added a comment to D88460: Strlen loop idiom recognition.
In D88460#2462158, @hiraditya wrote:
In D88460#2458205, @anjankgk wrote:
In D88460#2342937, @hiraditya wrote:

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Thanks for working on this.

Thank you for the feedback @hiraditya! I have tested the latest patch at various options (O2, O3, LTO and PGO) against the SPEC benchmarks as well as run the lnt tests and bootstrap tests successfully. If you were concerned about any other specific testsuite, pls let me know.

Nice, if we have performance improvements on any of the benchmarks/workloads then do share.

Dec 18 2020, 5:24 AM · Restricted Project, Restricted Project

Dec 16 2020

anjankgk added a comment to D88460: Strlen loop idiom recognition.
In D88460#2342937, @hiraditya wrote:

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Thanks for working on this.

Dec 16 2020, 9:16 AM · Restricted Project, Restricted Project
anjankgk added a comment to D88460: Strlen loop idiom recognition.
In D88460#2342407, @efriedma wrote:

Phabricator doesn't track incremental patches the way you're uploading them; please upload the full diff against master.

Dec 16 2020, 9:14 AM · Restricted Project, Restricted Project
anjankgk updated the diff for D88460: Strlen loop idiom recognition.

Changes from previous review comments:

  • Replaced LCSSAEv->getStart() by LoadEv->getStart()
  • Added another test function where multiple LCSSAPhi nodes were present and therefore shouldn't have replaced with strlen function.
Dec 16 2020, 9:12 AM · Restricted Project, Restricted Project

Oct 19 2020

anjankgk updated the diff for D88460: Strlen loop idiom recognition.

Rewrite the LCSSAPhi instruction to reflect strlen idiom recognition.

Oct 19 2020, 3:27 PM · Restricted Project, Restricted Project

Oct 15 2020

anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 15 2020, 2:37 PM · Restricted Project, Restricted Project

Oct 7 2020

anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 7 2020, 8:05 PM · Restricted Project, Restricted Project
anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 7 2020, 3:31 PM · Restricted Project, Restricted Project
anjankgk updated the diff for D88460: Strlen loop idiom recognition.

Check for i8 type and use update_test_checks.py for testfile.

Oct 7 2020, 3:24 PM · Restricted Project, Restricted Project
anjankgk added inline comments to D88460: Strlen loop idiom recognition.
Oct 7 2020, 3:15 PM · Restricted Project, Restricted Project

Oct 2 2020

anjankgk added a comment to D88460: Strlen loop idiom recognition.

Gentle ping..

Oct 2 2020, 6:47 AM · Restricted Project, Restricted Project
anjankgk added reviewers for D88460: Strlen loop idiom recognition: bmahjour, etiotto.
Oct 2 2020, 6:46 AM · Restricted Project, Restricted Project

Sep 28 2020

anjankgk requested review of D88460: Strlen loop idiom recognition.
Sep 28 2020, 6:19 PM · Restricted Project, Restricted Project