This is an archive of the discontinued LLVM Phabricator instance.

Differential D106632

[OpenMP] always compile with c++14 instead of gnu++14
ClosedPublic

Authored by ye-luo on Jul 22 2021, 8:24 PM.

Details

Reviewers
jdoerfert
tianshilei1992
jhuber6
ggeorgakoudis
protze.joachim
Commits
rG4079037a3e11: [OpenMP] always compile with c++14 instead of gnu++14
Summary

Fixes PR 51174. c++14 should be a more portable option than gnu++14.

Diff Detail

Event Timeline

ye-luo created this revision.Jul 22 2021, 8:24 PM
Herald added subscribers: guansong, yaxunl, mgorny. · View Herald TranscriptJul 22 2021, 8:24 PM
ye-luo requested review of this revision.Jul 22 2021, 8:24 PM
Herald added a subscriber: sstefan1. · View Herald TranscriptJul 22 2021, 8:24 PM
Harbormaster completed remote builds in B115766: Diff 361074.Jul 22 2021, 9:17 PM
jdoerfert added reviewers: tianshilei1992, jhuber6, ggeorgakoudis, protze.joachim.Jul 23 2021, 7:27 AM
tianshilei1992 added a comment.Jul 23 2021, 11:31 AM

I think that is good, but I'm not quite sure why it favors gnu++14 instead of c++14 at the first place, though I did the update from 11 to 14, but the logic to use GNU first is not on me.

ye-luo added a comment.Jul 23 2021, 2:02 PM

I think we just move on. If someone really need gnu++14, they must explain the reason and we keep a record in the comment.

tianshilei1992 accepted this revision.Jul 23 2021, 2:21 PM

LGTM. If any issue occurs, we can revise it later.

This revision is now accepted and ready to land.Jul 23 2021, 2:21 PM
Closed by commit rG4079037a3e11: [OpenMP] always compile with c++14 instead of gnu++14 (authored by ye-luo, committed by tianshilei1992). · Explain WhyJul 23 2021, 2:29 PM
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rG4079037a3e11: [OpenMP] always compile with c++14 instead of gnu++14.
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2021, 2:29 PM

Revision Contents

PathSize
openmp/
cmake/
5 lines
1 line

Diff 361354

openmp/cmake/HandleOpenMPOptions.cmake

Show All 23 Lines
append_if(OPENMP_HAVE_WIMPLICIT_FALLTHROUGH_FLAG "-Wimplicit-fallthrough" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_WIMPLICIT_FALLTHROUGH_FLAG "-Wimplicit-fallthrough" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
append_if(OPENMP_HAVE_WSIGN_COMPARE_FLAG "-Wsign-compare" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_WSIGN_COMPARE_FLAG "-Wsign-compare" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
# Warnings that we want to disable because they are too verbose or fragile. # Warnings that we want to disable because they are too verbose or fragile.
append_if(OPENMP_HAVE_WNO_EXTRA_FLAG "-Wno-extra" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_WNO_EXTRA_FLAG "-Wno-extra" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
append_if(OPENMP_HAVE_WNO_PEDANTIC_FLAG "-Wno-pedantic" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_WNO_PEDANTIC_FLAG "-Wno-pedantic" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
append_if(OPENMP_HAVE_WNO_MAYBE_UNINITIALIZED_FLAG "-Wno-maybe-uninitialized" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_WNO_MAYBE_UNINITIALIZED_FLAG "-Wno-maybe-uninitialized" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
append_if(OPENMP_HAVE_STD_GNUPP14_FLAG "-std=gnu++14" CMAKE_CXX_FLAGS)
if (NOT OPENMP_HAVE_STD_GNUPP14_FLAG)
append_if(OPENMP_HAVE_STD_CPP14_FLAG "-std=c++14" CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_STD_CPP14_FLAG "-std=c++14" CMAKE_CXX_FLAGS)
endif()

openmp/cmake/config-ix.cmake

include(CheckCXXCompilerFlag) include(CheckCXXCompilerFlag)
check_cxx_compiler_flag(-Wall OPENMP_HAVE_WALL_FLAG) check_cxx_compiler_flag(-Wall OPENMP_HAVE_WALL_FLAG)
check_cxx_compiler_flag(-Werror OPENMP_HAVE_WERROR_FLAG) check_cxx_compiler_flag(-Werror OPENMP_HAVE_WERROR_FLAG)
# Additional warnings that are not enabled by -Wall. # Additional warnings that are not enabled by -Wall.
check_cxx_compiler_flag(-Wcast-qual OPENMP_HAVE_WCAST_QUAL_FLAG) check_cxx_compiler_flag(-Wcast-qual OPENMP_HAVE_WCAST_QUAL_FLAG)
check_cxx_compiler_flag(-Wformat-pedantic OPENMP_HAVE_WFORMAT_PEDANTIC_FLAG) check_cxx_compiler_flag(-Wformat-pedantic OPENMP_HAVE_WFORMAT_PEDANTIC_FLAG)
check_cxx_compiler_flag(-Wimplicit-fallthrough OPENMP_HAVE_WIMPLICIT_FALLTHROUGH_FLAG) check_cxx_compiler_flag(-Wimplicit-fallthrough OPENMP_HAVE_WIMPLICIT_FALLTHROUGH_FLAG)
check_cxx_compiler_flag(-Wsign-compare OPENMP_HAVE_WSIGN_COMPARE_FLAG) check_cxx_compiler_flag(-Wsign-compare OPENMP_HAVE_WSIGN_COMPARE_FLAG)
# Warnings that we want to disable because they are too verbose or fragile. # Warnings that we want to disable because they are too verbose or fragile.
check_cxx_compiler_flag(-Wno-extra OPENMP_HAVE_WNO_EXTRA_FLAG) check_cxx_compiler_flag(-Wno-extra OPENMP_HAVE_WNO_EXTRA_FLAG)
check_cxx_compiler_flag(-Wno-pedantic OPENMP_HAVE_WNO_PEDANTIC_FLAG) check_cxx_compiler_flag(-Wno-pedantic OPENMP_HAVE_WNO_PEDANTIC_FLAG)
check_cxx_compiler_flag(-Wno-maybe-uninitialized OPENMP_HAVE_WNO_MAYBE_UNINITIALIZED_FLAG) check_cxx_compiler_flag(-Wno-maybe-uninitialized OPENMP_HAVE_WNO_MAYBE_UNINITIALIZED_FLAG)
check_cxx_compiler_flag(-std=gnu++14 OPENMP_HAVE_STD_GNUPP14_FLAG)
check_cxx_compiler_flag(-std=c++14 OPENMP_HAVE_STD_CPP14_FLAG) check_cxx_compiler_flag(-std=c++14 OPENMP_HAVE_STD_CPP14_FLAG)