This is an archive of the discontinued LLVM Phabricator instance.

Differential D106630

[AbstractAttributor] Refine logic to indicate pessimistic fixed point when folding `__kmpc_is_spmd_exec_mode`
ClosedPublic

Authored by tianshilei1992 on Jul 22 2021, 7:16 PM.

Details

Reviewers
uenoku
jdoerfert
sstefan1
baziotis
Commits
rGae69f46867cd: [AbstractAttributor] Refine logic to indicate pessimistic fixed point when…
Summary

Since we are using assumed information now, the logic should be refined to avoid
unncessary assertion.

Diff Detail

Unit TestsFailed

TimeTest
2,990 msx64 debian > libarcher.critical::critical.c
2,720 msx64 debian > libarcher.critical::lock-nested.c
2,890 msx64 debian > libarcher.parallel::parallel-firstprivate.c
2,890 msx64 debian > libarcher.races::critical-unrelated.c
2,900 msx64 debian > libarcher.races::lock-nested-unrelated.c
View Full Test Results (20 Failed)

Event Timeline

tianshilei1992 created this revision.Jul 22 2021, 7:16 PM
Herald added a reviewer: uenoku. · View Herald TranscriptJul 22 2021, 7:16 PM
Herald added subscribers: ormris, okura, uenoku, hiraditya. · View Herald Transcript
tianshilei1992 requested review of this revision.Jul 22 2021, 7:16 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJul 22 2021, 7:16 PM
Herald added a reviewer: jdoerfert. · View Herald Transcript
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, bbn, sstefan1. · View Herald Transcript
jdoerfert accepted this revision.Jul 22 2021, 7:34 PM

LG

This revision is now accepted and ready to land.Jul 22 2021, 7:34 PM
Harbormaster completed remote builds in B115761: Diff 361067.Jul 22 2021, 9:04 PM
This revision was landed with ongoing or failed builds.Jul 23 2021, 10:36 AM
Closed by commit rGae69f46867cd: [AbstractAttributor] Refine logic to indicate pessimistic fixed point when… (authored by tianshilei1992). · Explain Why
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rGae69f46867cd: [AbstractAttributor] Refine logic to indicate pessimistic fixed point when….

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
6 lines

Diff 361067

llvm/lib/Transforms/IPO/OpenMPOpt.cpp

Show First 20 Lines • Show All 3,672 Lines • ▼ Show 20 Lines for (Kernel K : CallerKernelInfoAA.ReachingKernelEntries) {
} else { } else {
if (AA.SPMDCompatibilityTracker.isAtFixpoint()) if (AA.SPMDCompatibilityTracker.isAtFixpoint())
++KnownNonSPMDCount; ++KnownNonSPMDCount;
else else
++AssumedNonSPMDCount; ++AssumedNonSPMDCount;
} }
} }
if (KnownSPMDCount && KnownNonSPMDCount) if ((AssumedSPMDCount + KnownSPMDCount) &&
return indicatePessimisticFixpoint(); (AssumedNonSPMDCount + KnownNonSPMDCount))
if (AssumedSPMDCount && AssumedNonSPMDCount)
return indicatePessimisticFixpoint(); return indicatePessimisticFixpoint();
auto &Ctx = getAnchorValue().getContext(); auto &Ctx = getAnchorValue().getContext();
if (KnownSPMDCount || AssumedSPMDCount) { if (KnownSPMDCount || AssumedSPMDCount) {
assert(KnownNonSPMDCount == 0 && AssumedNonSPMDCount == 0 && assert(KnownNonSPMDCount == 0 && AssumedNonSPMDCount == 0 &&
"Expected only SPMD kernels!"); "Expected only SPMD kernels!");
// All reaching kernels are in SPMD mode. Update all function calls to // All reaching kernels are in SPMD mode. Update all function calls to
// __kmpc_is_spmd_exec_mode to 1. // __kmpc_is_spmd_exec_mode to 1.
▲ Show 20 Lines • Show All 494 Lines • Show Last 20 Lines