Page MenuHomePhabricator

[Attributor][FIX] checkForAllInstructions, correctly handle declered functions

Authored by kuter on Jul 22 2021, 6:07 PM.



checkForAllInstructions was not handling declared functions correctly.
It should have been returning false when it gets called on a declared function.

The patch also fixes a test case for AAFunctionReachability for it to be able
to pass after the changes to the checkForAllinstructions.

Diff Detail

Event Timeline

kuter created this revision.Jul 22 2021, 6:07 PM
kuter requested review of this revision.Jul 22 2021, 6:07 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
jdoerfert accepted this revision.Jul 22 2021, 6:11 PM

LG. Call them declarations int the commit message and subject, not declared function (a definition is also a declaration and declares a function but people will know).

This revision is now accepted and ready to land.Jul 22 2021, 6:11 PM
This revision was landed with ongoing or failed builds.Jul 23 2021, 4:23 PM
This revision was automatically updated to reflect the committed changes.