This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][NFC] Modify isAssumedHeapToStack for const argument
ClosedPublic

Authored by ggeorgakoudis on Jul 20 2021, 7:49 PM.

Details

Summary

There is no need for a non-const argument interface and the const argument modification covers existing and upcoming use cases.

Diff Detail

Event Timeline

ggeorgakoudis created this revision.Jul 20 2021, 7:49 PM
ggeorgakoudis requested review of this revision.Jul 20 2021, 7:49 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
ggeorgakoudis edited the summary of this revision. (Show Details)Jul 20 2021, 7:50 PM
jdoerfert accepted this revision.Jul 20 2021, 8:45 PM

LG, but replace the old one, no need to have a non-const version.

This revision is now accepted and ready to land.Jul 20 2021, 8:45 PM

Fix for comments

ggeorgakoudis retitled this revision from [Attributor][NFC] Add a const argument isAssumedHeapToStack to [Attributor][NFC] Modify isAssumedHeapToStack for const argument.Jul 21 2021, 1:07 AM
ggeorgakoudis edited the summary of this revision. (Show Details)
ggeorgakoudis edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jul 21 2021, 10:28 AM
This revision was automatically updated to reflect the committed changes.