This is an archive of the discontinued LLVM Phabricator instance.

[AbstractAttributor] Fix two issues in folding __kmpc_is_spmd_exec_mode
ClosedPublic

Authored by tianshilei1992 on Jul 16 2021, 8:45 PM.

Details

Summary

This patch fixed two issues found when folding __kmpc_is_spmd_exec_mode:

  1. When the reaching kernels are empty, it should not fold to generic mode.
  2. When creating AA for the caller when updating information, the dependency should be required.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jul 16 2021, 8:45 PM
tianshilei1992 requested review of this revision.Jul 16 2021, 8:45 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

check SimplifiedValue when empty reaching kernels

ye-luo accepted this revision.Jul 17 2021, 9:38 AM
ye-luo added a subscriber: ye-luo.

I checked both the reproducer and miniQMC. The reported bug https://bugs.llvm.org/show_bug.cgi?id=51124 can be fixed by this patch.

This revision is now accepted and ready to land.Jul 17 2021, 9:38 AM
This revision was landed with ongoing or failed builds.Jul 17 2021, 10:13 AM
This revision was automatically updated to reflect the committed changes.