This is an archive of the discontinued LLVM Phabricator instance.

Enable Flang by default in the test-release.sh script
ClosedPublic

Authored by awarzynski on Jul 13 2021, 4:03 AM.

Details

Summary

I've also brought this up on llvm-dev:

https://lists.llvm.org/pipermail/llvm-dev/2021-July/151744.html

Diff Detail

Event Timeline

awarzynski created this revision.Jul 13 2021, 4:03 AM
awarzynski requested review of this revision.Jul 13 2021, 4:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2021, 4:03 AM
simoll added a subscriber: simoll.Jul 13 2021, 4:23 AM
rovka accepted this revision.Jul 13 2021, 4:34 AM

LGTM.

llvm/utils/release/test-release.sh
175

Minor nitpick: Should we error out if people explicitly pass -no-mlir but not -no-flang?

This revision is now accepted and ready to land.Jul 13 2021, 4:34 AM
Leporacanthicus added inline comments.
llvm/utils/release/test-release.sh
175

Or like "libs" which only looks at the other libs if the overall libs are enabled, so flang would go inside the mlir part.

Not sure which is more natural. You almost certainly don't want flang if you have said no to MLIR.

Make sure that we don't try building Flang with MLIR disabled

@rovka , @Leporacanthicus - good point, thank you!

awarzynski marked 2 inline comments as done.Jul 15 2021, 5:05 AM
This revision was landed with ongoing or failed builds.Jul 15 2021, 9:18 AM
This revision was automatically updated to reflect the committed changes.